fix: typescript/remove-public-modifier: keep private/protected #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only remove public modifier, keep any private/protected modifiers.
amirabbas-gh
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This is codemod-com/codemod#1414 for the right repository.
Only remove public modifier, keep
any private/protected modifiers.
🔗 Linked Issue
No issue.
🧪 Test Plan
Not sure, I get a lot of failures with
pnpm recursive run testin the node:20 docker container.Test passed in the PR for the other repository.
📄 Documentation to Update
Bug fix, no functional change compared to the documentation.