-
Notifications
You must be signed in to change notification settings - Fork 30
Feature/issue77 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mabigel
wants to merge
17
commits into
codemetropolis:develop
Choose a base branch
from
mabigel:feature/issue77
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/issue77 #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sibility of functions in Buildings. Adding theme parameter to command line parameters.
…ing to Buildable.java. Writing Javadoc to railway layout classes.
…street. Cellars are represented similarly to floors, above the ground.
… houses are single floored with a nice roof. Gardens are placed along a long street.
…oint and Time general classes. Added missing exception handling to DecorationFloor. Also added jUnit to the modules using test scope.
… imports and minor issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of issue 77 and issue 80 for the Rendszerfejlesztés II. course at University of Szeged.
Issue 77
According to the task I have created the opportunity for the user to personalize the look and feel of the city. First of all, new layout algorithm have been created, which are responsible for placing the buildings in their correct position. Besides the user can choose a theme, which determines the structure (and the material) of the buildings.
These new features provide more options to theming the world in an easy to use, user-friendly way.
Layout algorithms
Theming
There is now the option to choose a theme for the generated world. It was implemented in a way that new themes can be easily added in the future.
Issue 80
I have also added the work of Dora Borsos and Bernat Gecs to this pull request, who implemented issue 80. Their description of their work:
"Show metrics without leaving the visualization.
At first read all the block which are not decorationFloor from the placing-results.xml and match them with items in the converter-results.xml. Write the names, identifiers and metrics for all blocks from these files into a csv file called metrics.csv and place it in the current Minecraft world folder.
In the visualization first press F3 key to show the debugger information provided by Minecraft then press F4 to switch to show the current metrics and press again to switch back to debugger info. If you decide to show the metrics the game will search for the file called metrics.csv in the Minecraft world folder and read all its content and show it on the screen. The metrics are updated realtime as you look at any block that has metrics information."
~ Dora Borsos & Bernat Gecs