Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldplay126
approved these changes
Mar 12, 2025
Comment on lines
+12
to
+15
| <div onClick={() => (window.location.href = "/privacy")}> | ||
| Privacy Policy | ||
| </div> | ||
| <div onClick={() => (window.location.href = "/faq")}>FAQ</div> |
There was a problem hiding this comment.
리액트를 사용해 보고 계시니 js 기본 기능이 아닌 link 를 사용해보시는건 어떨까요?
link
Comment on lines
+9
to
+16
| useEffect(() => { | ||
| const fetchData = async () => { | ||
| const newBestProducts = await getProductsList(1, 4, "favorite", ""); | ||
| setBestProductsState(newBestProducts); | ||
| }; | ||
|
|
||
| fetchData(); | ||
| }, []); |
There was a problem hiding this comment.
getProductsList 변수를 하드 코딩이 아닌 다른 방식으로 처리해 보시는건 어떨까요?
| @@ -0,0 +1,32 @@ | |||
| // eslint-disable-next-line react/prop-types | |||
There was a problem hiding this comment.
eslint 여기서 비활성화 하신 이유가 있을까요? react/prop-types가 발생하는게 부담스러운 경우 eslint.config.js에서 비활성화 해 주시는게 더 좋습니다!
Comment on lines
+10
to
+11
| src={product.images[0]} | ||
| alt={product.name} |
There was a problem hiding this comment.
이미지가 없는 경우 product.images[0]는 어떻게 될까요? 방어코드가 추가되면 더욱 좋을 것 같습니다!
Comment on lines
+8
to
+12
| const keyPressHandler = (e) => { | ||
| if (e.key === "Enter") { | ||
| setSearchByState(searchByInputState); | ||
| } | ||
| }; |
There was a problem hiding this comment.
enter를 눌렀을 때만 검색되도록 작업하신 점 훌륭합니다! 매 입력시 API를 호출한다면 서버에도 부담이 많이 되겠죠.
다만 현 코드에서 유저가 enter를 입력해야 검색이 된다는 것을 알 수 있을까요? 유저에게 인지시킬 방법이 있는지 생각해 보면 좋을 것 같습니다!
coldplay126
merged commit dc9fb6c
into
codeit-sprint-fullstack:react-김재욱
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게