Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[김다은] sprint5 #136

Conversation

fs6-kde
Copy link
Collaborator

@fs6-kde fs6-kde commented Mar 9, 2025

https://effervescent-malabi-4819d6.netlify.app/

요구사항

기본

  • [x]
  • []
  • []

심화

  • [x]
  • []

주요 변경사항

스크린샷

image

멘토에게

  • 미션 데이터가 연결이 안되어 급하게 다른 데이터로 작성하였습니다
  • npm install 이 안되어 최대한 복사해서 붙여넣었습니다...

@fs6-kde fs6-kde self-assigned this Mar 9, 2025
@fs6-kde fs6-kde requested a review from AlskaPark March 9, 2025 15:02
Copy link
Collaborator

@AlskaPark AlskaPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 잘 작성해주셨습니다 :) package.jsonpackage-lock.json 그리고 vite.config.js는 프로젝트 root로 빼주시면 좋을거 같아요~!

setItems(reviews);
}
} catch (e) {
console.error("리뷰를 불러오는 중 오류 발생:", e);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분도 state로 만들어서 처리했으면 좋을거 같네요 :) "다시 시도하기"라던지 에러 페이지를 보여주셔도 좋구요.


const ReviewListItem = ({ item }) => {
return (
<div className="ReviewListItem">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class이름은 kebak-case를 사용해주시는게 일반적인 관습입니다 :)

@AlskaPark AlskaPark merged commit 441aed0 into codeit-sprint-fullstack:react-김다은 Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants