Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlskaPark
approved these changes
Mar 10, 2025
|
|
||
|
|
||
| // GET 메서드를 사용하여 기사 목록을 가져오는 함수 | ||
| function getArticleList(page = 1, pageSize = 10, keyword = '???') { |
There was a problem hiding this comment.
기본값으로는 ''(빈 문자열) 또는 null을 사용하는 것이 좋습니다. 일반적으로 코드에서 비어있는 값을 따로 처리하는 관례가 있기 때문입니다.
| return response.json(); | ||
| }) | ||
| .then(data => { | ||
| console.log(data); |
There was a problem hiding this comment.
포맷팅은 작업 후 한번씩 해주시면 좋습니다. 실무에서는 어쩌면 사소하지만 채용시장에서 상당히 중요하게 작용할 수 있습니다!
| function getArticleList(page = 1, pageSize = 10, keyword = '???') { | ||
| const url = `https://panda-market-api-crud.vercel.app/articles/?page=${page}&pageSize=${pageSize}&keyword=${keyword}`; | ||
|
|
||
| fetch(url) |
There was a problem hiding this comment.
아마 console.log로 작동을 확인해서 return을 안 하신거 같습니다..ㅎㅎ return을 해주시고 함수 밖에서 console.log로 확인해보시길 권장합니다. 왜냐하면 내부 console.log는 해당 함수와는 관련이 없는 테스트 코드이기 때문입니다.
| @@ -0,0 +1,3 @@ | |||
| [ZoneTransfer] | |||
There was a problem hiding this comment.
.identifier는 .gitignore에 등록해주시면 좋습니다 :)
| function getBestPageSize() { | ||
| const width = window.innerWidth; | ||
| if (width >= 1200) { | ||
| return 4; // pc화면 |
There was a problem hiding this comment.
이런 값을 magic number라고 하는데요. 상수로 빼서 이름을 붙여주면 좋습니다~!
| const BASE_URL = "https://panda-market-api.vercel.app"; | ||
|
|
||
| //Get 메서드를 이용하여 제품 목록을 가져오는 함수 | ||
| async function GetProductList(options) { |
There was a problem hiding this comment.
export 함수의 시작을 대분자로 하는 언어도 있는데요. JavaScript 진영에서는 권장하지 않는 방법입니다. getProductList와 같이 camelCase를 사용하시는걸 권장드려요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
멘토에게