-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[가승연] Sprint 8 #112
Merged
dennis2311
merged 16 commits into
codeit-sprint-fullstack:next-가승연
from
Syyga:next-가승연-sprint8
Mar 5, 2025
The head ref may contain hidden characters: "next-\uAC00\uC2B9\uC5F0-sprint8"
Merged
[가승연] Sprint 8 #112
dennis2311
merged 16 commits into
codeit-sprint-fullstack:next-가승연
from
Syyga:next-가승연-sprint8
Mar 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis2311
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 주석! 주석 적극적으로 사용해주세요! 주석 없이 작업을 진행하기엔 이미 사이즈가 많이 크실텐데...
- React 컴포넌트를 반환하는 파일의 확장자는 .jsx 로 지어주세요. .js 확장자는 로직을 담당하는 경우에만 사용할 수 있도록 분리하는 편이 좋습니다.
- ArticleDetail.js, Nav.js 등의 파일들은 대문자로 시작하지만 다른 파일들은 소문자로 시작하고 있는데, 특별한 이유가 없다면 파일 네이밍 규칙은 통일하는 것이 좋습니다.
- React 컴포넌트를 반환하는 파일에서 useState -> useContext -> 사용하는 함수 -> useEffect -> HTML 구성요소 순서대로 정의해 가는 규칙이 있는 점이 대단히 좋습니다. 이런 사소한 규칙들이 생산성을 향상시키는 요소가 됩니다.
- 다만 꼭 필요한 경우가 아니라면 저는 함수 선언에 const 를 지양하는 편입니다. function 이라는 단어 자체가 시각적, 기능적으로 구별되기도 하고 hoisting 도 되기 때문에 혹여 함수가 쓰이는 곳 이후에 선언되더라도 문제가 되지 않기 때문입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배포 주소 : https://syga-panda.netlify.app/