-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[김현우] Sprint 10 #71
base: express-김현우
Are you sure you want to change the base?
[김현우] Sprint 10 #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
보통
-route
-controller
-service
이렇게 나누고 대부분의 로직이 service에 들어가게 되는데 service는 사용안하고 있는 것 같아서 추천드립니다.
const { generateToken, generateRefreshToken } = require("../utils/jwt"); | ||
|
||
exports.signUp = async (req, res) => { | ||
const { email, password, nickname } = req.body; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
password 는 암호화 전인가요? 그러면 클라이언트에서 보낼때도 그냥 password스트링 그대로 보내나요?
}; | ||
|
||
exports.refreshToken = async (req, res) => { | ||
const { refreshToken } = req.body; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refreshToken 새로 발급할때 만료된 accessToken도 같이 받아오지는 않나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth middleware 에서 토큰검증을 한번 해서 상관 없으려나요
Pull Request: Weekly Mission for Backend Development
요구사항
기본
프론트엔드 구현 요구사항
중고마켓 페이지 (Secondhand Market Page)
상품 등록하기 페이지
백엔드 구현 요구사항
상품 등록
상품 상세
좋아요 기능
에러 처리
라우트 중복 제거
인증
상품 기능 인가
게시글 기능 인가
댓글 기능 인가
심화 요구사항
주요 변경사항
스크린샷
멘토에게 (To the Mentor)