-
Notifications
You must be signed in to change notification settings - Fork 77
[고한샘] sprint10 #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gohansaem1
wants to merge
28
commits into
codeit-bootcamp-frontend:main
Choose a base branch
from
gohansaem1:Next.js-고한샘-sprint10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "Next.js-\uACE0\uD55C\uC0D8-sprint10"
Open
[고한샘] sprint10 #663
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
87e3f15
chore: 머지 후 브랜치 삭제 github action 추가
withyj-codeit 1472169
Initial commit from Create Next App
withyj-codeit 671d4d5
reset
hanseulhee 14baca2
fix: 머지 후 브랜치 삭제 github action 수정
hanseulhee 8d163dd
env: workflows 폴더로 이동
hanseulhee cf2e3df
Merge branch 'Next.js-고한샘' of https://github.com/codeit-bootcamp-fron…
gohansaem1 398ac6c
fix: 불필요파일 제거, 필요아이콘 세팅
gohansaem1 a04698a
test css, 라우팅, 검색쿼리
gohansaem1 8f535bd
배포 브랜치 변경용 커밋
gohansaem1 921aec0
배포 중 오류 해결
gohansaem1 f56d696
배포 중 오류 해결 2
gohansaem1 2ee994e
배포 중 오류 해결 3
gohansaem1 d80a89a
모르겠다
gohansaem1 5d76a22
.
gohansaem1 6f12196
.
gohansaem1 6cdee27
..
gohansaem1 af57418
버셀, 빌드코드제거
gohansaem1 c0b2b55
dfd
gohansaem1 c5cd127
게시판 글 가져오기 api 확인
gohansaem1 069ebed
feat: 검색 기능 구현
gohansaem1 c59c0eb
feat: 드롭다운 버튼 기능구현
gohansaem1 365a414
feat: 공통 헤더 컴포넌트 추가
gohansaem1 b690f65
feat:설정페이지 테마기능 구현
gohansaem1 d3bb2bb
fix: header css 수정, 구글폰트 적용하기
gohansaem1 eb445b0
fix: 네트리파이 빌드오류
gohansaem1 b3d39fd
fix: 타입스크립트 변환
gohansaem1 fbb8fcf
feat/ 글쓰기 버튼 컴포넌트, addboard 링크 연결
gohansaem1 270af41
feat: 개별 게시글 페이지, 댓글 달기 기본레이아웃 구성 구현
gohansaem1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| .write { | ||
| width: 84px; | ||
| height: 42px; | ||
| border-radius: 8px; | ||
| background-color: #3692ff; | ||
| font-family: Pretendard; | ||
| font-size: 16px; | ||
| font-weight: 600; | ||
| color: #ffffff; | ||
| text-align: center; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import styles from "@/components/BlueButton.module.css"; | ||
|
|
||
| export default function BlueButton({ children }) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. export const BlueButton:React.FC<PropsWithChildren> = ({ children }) => {이렇게하면 타입을 지정할 수 있어요 |
||
| return <div className={styles.write}>{children}</div>; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ const SearchForm: React.FC<SearchFormProps> = ({ | |
|
|
||
| if (!value) { | ||
| router.push("/boards"); | ||
| onChangeKeyword(" "); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. empty string이 아니라 공백으로 처리하는게 맞나요? |
||
| return; | ||
| } | ||
| if (onChangeKeyword) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export default function AddBoard() { | ||
| return ( | ||
| <> | ||
| <h2>add</h2> | ||
| </> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 버튼에만
Pretendard가 적용되어야 하나요?그런게 아니라면 font는 최상위 node에서 사용하는게 좋을것 같습니다 ㅎ