-
Notifications
You must be signed in to change notification settings - Fork 26
[최지은] sprint5 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ByungyeonKim
merged 40 commits into
codeit-bootcamp-frontend:React-최지은
from
Jiii-Eun:React-최지은
Aug 12, 2025
The head ref may contain hidden characters: "React-\uCD5C\uC9C0\uC740"
Merged
[최지은] sprint5 #93
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
fc5dffe
chore: PR 템플릿 추가
withyj-codeit 93a0e93
chore: 머지 후 브랜치 삭제 github action 추가
withyj-codeit b2e37bd
reset
hanseulhee 6f8bbb0
Merge branch 'codeit-bootcamp-frontend:main' into main
hanseulhee e11e25f
fix: 머지 후 브랜치 삭제 github action 수정
hanseulhee 212e864
env: workflows 폴더로 이동
hanseulhee 4dc5dd0
Merge pull request #237 from hanseulhee/fix-github-actions
withyj-codeit 0c818c3
First sprint
Jiii-Eun b449d64
Merge pull request #1 from Jiii-Eun/Basic-최지은-sprint1
baeggmin 01ec6df
redactor: 폴더 정리 및 파일 이동
Jiii-Eun b265e5c
refactor(mentor): sprint1 수정과 sprint2첫번째 완성
Jiii-Eun e248809
Style.css파일 삭제
Jiii-Eun 7b54837
Change file 작업전추가
Jiii-Eun e5e2cf2
Conflict 수정
Jiii-Eun c846b85
Refactor: auth.css submit에 cursor추가
Jiii-Eun cf47d79
Refactor: sprint2 수정
Jiii-Eun 29422d4
Refactor(mentor): 테블릿, 모바일크기 설정
Jiii-Eun 928c117
Meta태그 추가 및 수정
Jiii-Eun e84e75e
Refactor(mentor): spring3완성
Jiii-Eun cf77c9c
refactor: auth.css 중복 padding삭제
Jiii-Eun 9ae66b0
refactor: height수정
Jiii-Eun 7abdb3a
feat: sprint4완성
Jiii-Eun b991613
refactor: 비밀번호 일치 수정
Jiii-Eun 0629498
refactor: 코드 위치 변경
Jiii-Eun ecdfd77
refactor: 로그인 js연결
Jiii-Eun 6bbfd80
refactor: submit버튼 수정필요
Jiii-Eun 90c4ca0
refactor: submit버튼 활성화
Jiii-Eun e4cf89b
refactor: 코드 위치수정
Jiii-Eun f5385ac
refactor: submit상태 코드 유효성 추가
Jiii-Eun 00e5395
feat: items구조 및 api 연결
Jiii-Eun 7fe3cc8
feat: 초기세팅, items구조, api 연결
Jiii-Eun 427d7bf
파일 복구
Jiii-Eun 746bc94
중간 저장
Jiii-Eun 99eb977
feat: 공통스타일 및 헤더푸터 스타이리 설정
Jiii-Eun 98a3274
feat: items페이지 구현
Jiii-Eun f55ea9f
style: PageList 스타일 분리
Jiii-Eun 838e468
style: itemOrder 커서 통일
Jiii-Eun d58466e
docs: readme삭제
Jiii-Eun 13c1c71
Merge branch 'React-최지은-sprint5' into React-최지은
Jiii-Eun 83a0bcf
fix: 캐시삭제
Jiii-Eun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| ## 요구사항 | ||
|
|
||
| ### 기본 | ||
|
|
||
| - [x] | ||
| - [] | ||
| - [] | ||
|
|
||
| ### 심화 | ||
|
|
||
| - [x] | ||
| - [] | ||
|
|
||
| ## 주요 변경사항 | ||
|
|
||
| - | ||
| - | ||
|
|
||
| ## 스크린샷 | ||
|
|
||
|  | ||
|
|
||
| ## 멘토에게 | ||
|
|
||
| - | ||
| - | ||
| - 셀프 코드 리뷰를 통해 질문 이어가겠습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: delete branch on close pr | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [closed] | ||
|
|
||
| jobs: | ||
| delete-branch: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: delete branch | ||
| uses: SvanBoxel/delete-merged-branch@main | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| *.local | ||
|
|
||
| # Editor directories and files | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| .DS_Store | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| .material-symbols-outlined { | ||
| font-variation-settings: "FILL" 0, "wght" 400, "GRAD" 0, "opsz" 24; | ||
| } | ||
| * { | ||
| color: var(--gray-800); | ||
| } | ||
| html, | ||
| body { | ||
| height: 100%; | ||
| } | ||
|
|
||
| .auth_container { | ||
| min-height: 100%; | ||
| min-width: 16rem; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| .width_container { | ||
| max-width: 40rem; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .user_input label, | ||
| .user_input input, | ||
| .auth.btn { | ||
| display: block; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .user_input label { | ||
| font-size: 1.125rem; | ||
| font-weight: 700; | ||
| margin-bottom: 1rem; | ||
| } | ||
|
|
||
| .user_input input, | ||
| .auth.btn { | ||
| margin-bottom: 1.5rem; | ||
| } | ||
|
|
||
| .logo { | ||
| justify-content: center; | ||
| margin-bottom: 2.5rem; | ||
| } | ||
| .logo h1 { | ||
| font-size: 4.15rem; | ||
| } | ||
| .logo_img { | ||
| max-width: 6.5rem; | ||
| } | ||
|
|
||
| .user_input input { | ||
| background-color: var(--gray-100); | ||
| border-radius: 0.75rem; | ||
| padding: 0 1.5rem; | ||
| } | ||
|
|
||
| .error_text { | ||
| position: absolute; | ||
| bottom: -1rem; | ||
| left: 0; | ||
| font-size: 0.875rem; | ||
| color: #ff0000; | ||
| } | ||
|
|
||
| .auth.btn { | ||
| font-size: 1.25rem; | ||
| font-weight: 600; | ||
| background-color: var(--gray-400); | ||
| } | ||
|
|
||
| .input_wrap { | ||
| position: relative; | ||
| } | ||
| .password_icon { | ||
| position: absolute; | ||
| right: 1.5rem; | ||
| top: 50%; | ||
| transform: translateY(-50%); | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .icon_cover { | ||
| width: 2.625rem; | ||
| height: 2.625rem; | ||
| border-radius: 50%; | ||
| overflow: hidden; | ||
| } | ||
| .sns_icon { | ||
| display: block; | ||
| } | ||
|
|
||
| .auth_text a { | ||
| color: var(--primary-100); | ||
| border-bottom: 0.06rem solid var(--primary-100); | ||
| } | ||
|
|
||
| .simple_login { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| margin-bottom: 1.5rem; | ||
| background-color: #e6f2ff; | ||
| padding: 1rem 1.5rem; | ||
| border-radius: var(--border-8); | ||
| } | ||
|
|
||
| .simple_login span { | ||
| word-break: keep-all; | ||
| font-weight: 500; | ||
| } | ||
| .sns_login { | ||
| display: flex; | ||
| justify-content: flex-end; | ||
| gap: 1rem; | ||
| } | ||
|
|
||
| .auth_helper { | ||
| text-align: center; | ||
| } | ||
| .auth_link { | ||
| margin-left: 0.3rem; | ||
| } | ||
|
|
||
| @media screen and (max-width: 767px) { | ||
| .auth_container { | ||
| padding: 1rem; | ||
| } | ||
|
|
||
| .logo h1 { | ||
| font-size: 2rem; | ||
| } | ||
| .logo_img { | ||
| max-width: 3.25rem; | ||
| } | ||
| .user_input label { | ||
| font-size: 0.875rem; | ||
| margin-bottom: 0.5rem; | ||
| } | ||
|
|
||
| .width_container { | ||
| max-width: 25rem; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| * { | ||
| color: var(--gray-700); | ||
| } | ||
| h2, | ||
| .main span { | ||
| font-weight: 700; | ||
| } | ||
| h2 { | ||
| font-size: 2.5rem; | ||
| word-break: keep-all; | ||
| line-height: 3rem; | ||
| } | ||
|
|
||
| section:not(.main) { | ||
| background-color: #cfe5ff; | ||
| } | ||
|
|
||
| .intro, | ||
| .ending { | ||
| padding-top: 4.2rem; | ||
| } | ||
| .flex_div { | ||
| height: 33rem; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: flex-end; | ||
| } | ||
| .title_div { | ||
| margin-bottom: 6.25rem; | ||
| width: 30rem; | ||
| } | ||
| .ending .title_div { | ||
| margin-bottom: 11rem; | ||
| } | ||
|
|
||
| .intro h2 { | ||
| margin-bottom: 2rem; | ||
| } | ||
|
|
||
| .intro .shopping { | ||
| display: block; | ||
| font-size: 1.25rem; | ||
| text-align: center; | ||
| width: 21rem; | ||
| } | ||
|
|
||
| .main img { | ||
| max-width: 36.75rem; | ||
| } | ||
| .main .card { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| gap: 3.5rem; | ||
| padding: 7rem 0; | ||
| } | ||
| .main .card.right { | ||
| flex-direction: row-reverse; | ||
| text-align: right; | ||
| } | ||
|
|
||
| .card_info span { | ||
| display: block; | ||
| font-size: 1.125rem; | ||
| color: var(--primary-100); | ||
| margin-bottom: 1.4rem; | ||
| } | ||
| .card_info h2 { | ||
| width: 18rem; | ||
| margin-bottom: 2.8rem; | ||
| } | ||
| .card_info p { | ||
| font-size: 1.5rem; | ||
| } | ||
|
|
||
| @media screen and (max-width: 1199px) { | ||
| .flex_div { | ||
| flex-direction: column; | ||
| justify-content: flex-end; | ||
| align-items: center; | ||
| gap: 5rem; | ||
| text-align: center; | ||
| } | ||
| .intro .flex_div { | ||
| height: 48rem; | ||
| } | ||
| .ending .flex_div { | ||
| height: 58rem; | ||
| } | ||
| .title_div { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| align-items: center; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .card_outter { | ||
| margin: 1.5rem; | ||
| } | ||
|
|
||
| .main .card.right { | ||
| flex-direction: column; | ||
| } | ||
| .main .card { | ||
| flex-direction: column; | ||
| align-items: unset; | ||
| padding: 0 0 3.25rem; | ||
| } | ||
| .main img { | ||
| max-width: 100%; | ||
| border-radius: var(--border-16); | ||
| } | ||
| .card_info h2 { | ||
| width: 100%; | ||
| font-size: 2rem; | ||
| margin-bottom: 1.5rem; | ||
| } | ||
| .card_info p { | ||
| font-size: 1.125rem; | ||
| } | ||
| } | ||
|
|
||
| @media screen and (max-width: 767px) { | ||
| .intro, | ||
| .ending { | ||
| padding-top: 0; | ||
| } | ||
|
|
||
| .flex_div { | ||
| height: 33.75rem; | ||
| } | ||
|
|
||
| .title_div { | ||
| max-width: 21rem; | ||
| } | ||
|
|
||
| .main .card { | ||
| padding: 1.5rem 0; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
왜
node_modules폴더는 원격 저장소에 올리지 않는 걸까요? 저는 용량 문제와 불필요한 변경 추적이 가장 큰 이유라고 생각해요.node_modules는 패키지 매니저(npm, yarn, pnpm 등)가package.json과package-lock.json(yarn.lock)을 기반으로 언제든 내 컴퓨터에서 재생성할 수 있는 폴더예요.기술 과제를 볼 때도
node_modules폴더는 꼭 제외한 후 제출하라고 주의를 주기도 하죠. 이 점 유의해 주세요! 🙂