refactor: fix Session
and SessionInterface
code
#9535
Merged
+112
−304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking at #9534 to find where the culprit is (in
markAsTempData()
), I found some points for improvements for the Session class:array|bool|float|int|object|string|null
is just the long form ofmixed
. If the type cannot be narrowed further (likestring|int|null
), I see no benefit in writing the long form instead of justmixed
.Checklist: