fix: improve error handling #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scme0
force-pushed
the
fix/404-status-update-should-fail-immediately
branch
3 times, most recently
from
c5be530 to
a73c521
Compare
eti-codefresh
approved these changes
Oct 9, 2025
|
Bumps |
scme0
force-pushed
the
fix/404-status-update-should-fail-immediately
branch
from
a73c521 to
259107c
Compare
scme0
force-pushed
the
fix/404-status-update-should-fail-immediately
branch
from
c34b7f1 to
8842783
Compare
|
/e2e |
mikhail-klimko
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Associated Operator PR: https://github.com/codefresh-io/codefresh-gitops-operator/pull/296
Adding the Completed property so we can know when to stop reconciling Promotion Tasks. The phase being "Succeeded", "Failed" etc is not enough as we need to know that this status has been sent to the platform before we stop reconciling.
Why
Notes