Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #81, Initial migration of WP blogs to md #101

Merged
merged 10 commits into from
Nov 1, 2022
Merged

Conversation

zenlex
Copy link
Collaborator

@zenlex zenlex commented Jul 7, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@zenlex zenlex added the hold putting this pr/issue on pause pending discussion label Jul 7, 2022
@zenlex
Copy link
Collaborator Author

zenlex commented Jul 7, 2022

Shout out to @higherkey for getting this wordpress conversion done. I spot checked a few of the MD files and it looks good. We'll want to do a full pass through the blogs with @chimchim237 once we get it deployed to staging to make any needed tweaks. Currently marked PR as on hold while @helmturner finishes up the MD parser refactor as the currently published version will break staging if I add the new markdown files. Once we've got Alec's new plugin deployed we'll merge these in as test material.

@higherkey
Copy link
Collaborator

One thing, the housekeeping branch that I published has a duplicate folder with all the files again. Should I remove all the duplicate stuff?

Also, we should specifically take a look at the images. The script attempted to grab images but I don't know how well it worked.

@zenlex zenlex force-pushed the housekeeping/blog-import branch from db7ac95 to a9a3bcc Compare October 30, 2022 23:48
@zenlex
Copy link
Collaborator Author

zenlex commented Oct 30, 2022

This will need someone to go through and fix frontmatter to conform to the schema in #113 and then should be good to merge.

@zenlex zenlex added documentation Improvements or additions to documentation good first issue Good for newcomers and removed hold putting this pr/issue on pause pending discussion labels Oct 30, 2022
@zenlex
Copy link
Collaborator Author

zenlex commented Nov 1, 2022

went through blogs and commented out or removed broken image links to allow it to build. Blog needs editorial review and then repair of any broken images deemed necessary.

@zenlex zenlex merged commit a075dde into dev Nov 1, 2022
@zenlex zenlex deleted the housekeeping/blog-import branch November 1, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants