Create Meal Form in Frontend #25
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Logan-Dang
commented
Jul 25, 2025
Logan-Dang
commented
- reglue dev server together
- implement auth in frontend
- create meal form in frontend
- implement auth in frontend - create meal form in frontend
Logan-Dang
force-pushed
the
create-meal-form
branch
from
c5f4754 to
7fca7f4
Compare
| return <AppConsumer />; | ||
| }); | ||
|
|
||
| const AppConsumer = component$(() => { |
There was a problem hiding this comment.
we should rename and place in own file as auth page im thinking
|
|
||
| const AppConsumer = component$(() => { | ||
| const form: Signal<'login' | 'register'> = useSignal('login'); | ||
| const darkMode = useSignal(localStorage.getItem('darkMode') === 'true'); |
There was a problem hiding this comment.
I think we should also abstract out the use of localStarage into own file so if we want to update it to cookies or something else, its a one place file change
|
|
||
| const toggleDarkMode = $(() => { | ||
| darkMode.value = !darkMode.value; | ||
| localStorage.setItem('darkMode', String(darkMode.value)); |
| user: Signal<User>; | ||
| }; | ||
|
|
||
| export const Dashboard = component$((props: DashboardProps) => { |
There was a problem hiding this comment.
.... ya this whole file has, more than it needs, as well as very specific to meal tally, i appreciate it but likely not the direction should be taking at this time, think we can remove the specific to meal tally stuff but keep the dashboard page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.