-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] - Replace existing Contact List with MUI Data Grid #457
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
7408a2c
Replaced existing contact list with MUI Data Grid; Fixed variable for…
leekahung e4dd4e7
Styled data grid
leekahung 411fb2c
Additional style changes to data grid
leekahung 1257771
Removing unneeded style changes for Contacts.jsx
leekahung 783eb60
Merge branch 'Development' into add-mui-data-grid
leekahung 15f632e
Updating test files
leekahung 418c2a3
Updates JSDoc comments for ContactProfileIcon and ContactListTable
leekahung bee5dd7
Update unit test using queryByRole
leekahung 30edfdd
Refactored ContactProfileIncon with onClick in Link instead of button…
leekahung e6d8ab0
Removed unused theme and moved style for Icon to sx in Icon
leekahung 3d46243
Included titleAccess to ContactPageIcon for accessibility
leekahung eedad01
Merge branch 'Development' into add-mui-data-grid
leekahung 00289da
Separating person into familyName and givenName
leekahung 7e083cd
Correcting unit test with grid update
leekahung f273ede
Merge branch 'Development' into add-mui-data-grid
leekahung 10730b0
Merge branch 'Development' into add-mui-data-grid
leekahung a8f645d
Merge branch 'Development' into add-mui-data-grid
leekahung ae54923
Correcting unit test with grid update
leekahung 35bd5a3
Merge branch 'Development' into add-mui-data-grid
leekahung c96988e
Merge branch 'Development' into add-mui-data-grid
leekahung e6212ec
Made grid columns stretch out to width
leekahung 1e16e07
Adjusting profile icon alignment in data grid
leekahung 5434683
Replacing custom sort with initialState sorting
leekahung 2631465
Adjusting dimensions for lower screen widths
leekahung f7070d0
Adjust UI for Contact page to make list fill out more of the page
leekahung 856c255
Merge branch 'Development' into add-mui-data-grid
leekahung 8cb453c
Merge branch 'Development' into add-mui-data-grid
leekahung 94176ad
Merge branch 'Development' into add-mui-data-grid
leekahung 066770f
Merge branch 'Development' into add-mui-data-grid
leekahung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this data grid what we used months back when creating the original table and implementing MUI? I don't recall why we decided not to go with it at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it was the same one as before. I think at the time we didn't went with it was because there were still a few thing we wish to discuss, although I don't remember which things.