Improve accessible name for links on home page #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekahung
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Ensures that links on the home page have accessible names.
1. Adds
aria-labels to links that surround images without text content2. Removes unnecessary
aria-labels where text content already exists3. Improved text content on link where it was unclear
The files this PR effects:
Components
Tests
Screenshots (if applicable):
Only visual difference is the text for the proposal button.
Additional Context (optional):
Most of these fixes were found using this extension.
Issues needing discussion/feedback (optional):
1. Want to make sure the "Make a proposal" text is desired, as that is more of a content choice then a technical one.