Add badge for unread messages #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbot1789
reviewed
Oct 6, 2023
timbot1789
approved these changes
Oct 6, 2023
Co-authored-by: Tim Standen <[email protected]>
|
There seems to be some failed checks before merger happened. If it's just the lint, think someone could open a PR to fix it. |
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONCISE description of PR (PR Title)
Add a badge for the inbox icon in the navbar that displays when the user has unread messages (mobile & desktop).
This PR:
Resolves #427 (#427)
The files this PR effects:
Components
NavMenu.jsx (Mobile)
NavbarDesktop.jsx (Desktop)
Other Files
MessageContext.jsx
Screenshots (if applicable):
Add any screenshots/videos here.
Future Steps/PRs Needed to Finish This Work (optional):
Small addition: An indicator for unread emails could also be displayed in the "inbox" tab within the /messages page. This tab could just display the number of unread emails in parentheses. This is how Gmail does it as pictured in the following screenshot:
This would be a very simple addition and I would be happy to implement it, if needed!