Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition from styled components to MUI for DocumentListTable.jsx and DocumentListTableRow.jsx #376

Closed
leekahung opened this issue Aug 10, 2023 · 8 comments
Closed

Transition from styled components to MUI for DocumentListTable.jsx and DocumentListTableRow.jsx #376

leekahung opened this issue Aug 10, 2023 · 8 comments
Assignees
@bingeboy
Labels
enhancement Enhancement of existing features

Comments

@leekahung
Copy link
Contributor

Describe the Current Behavior/Feature:

Currently we have an issue already opened for ClientListTable and ClientListTableRow to be updated from styled components to MUI in #219. However, DocumentListTable.jsx and DocumentListTableRow.jsx utilizes a lot of the same stylings. If the styling gets updated there, we would also need to update DocumentListTable and DocumentListTableRow as well during the transition.

Proposed Implementation (if applicable):

Simply need to update DocumentListTable and DocumentTableListRow as well during the swap from styled components to MUI.
@leekahung leekahung added the enhancement Enhancement of existing features label Aug 10, 2023
@leekahung leekahung mentioned this issue Aug 10, 2023
Closed
@cameronabel cameronabel self-assigned this Aug 16, 2023
@leekahung
Copy link
Contributor Author

Hey @cameronabel, just wanted to check up on the progress of this.

@leekahung
Copy link
Contributor Author

Think I'll unassign this for now. Let me know when activity for this issue picks up again, I'll have this re-assigned.

@bingeboy
Copy link
Contributor

@leekahung I'll grab this issue also

@leekahung
Copy link
Contributor Author

@leekahung I'll grab this issue also

Pick one and start from there

@bingeboy
Copy link
Contributor

@leekahung ok I'll start with #408

@leekahung
Copy link
Contributor Author

@leekahung ok I'll start with #408

If you think you could handle both issues and work on them, I'm fine with assigning this to you as well. 👍

We've been having issues recently where people gets assigned a task, but not end up working on them with little to no response back when checking up on the progress.

@andycwilliams
Copy link
Member

@bingeboy Are you currently working on this? If so, would you like to be assigned?

@bingeboy
Copy link
Contributor

@andycwilliams I haven't started it yet

@bingeboy bingeboy self-assigned this Sep 21, 2023
@bingeboy bingeboy mentioned this issue Sep 22, 2023
Merged
bingeboy added a commit that referenced this issue Oct 4, 2023
@bingeboy
Issue 376: Updated MUI component to used styled component
5b447b9 
Resolves #376
Resolves #219
bingeboy added a commit that referenced this issue Oct 4, 2023
@bingeboy
Merge pull request #433 from codeforpdx/issue-376-transition-from-sty…
9fcb38f 
…led-components-to-mui

Issue 376: Updated MUI component to used styled component
Resolves #376
Resolves #219
timbot1789 pushed a commit that referenced this issue Oct 6, 2023
@bingeboy @timbot1789
Issue 376: Updated MUI component to used styled component
a6d2226 
Resolves #376
Resolves #219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bingeboy bingeboy

Labels
enhancement Enhancement of existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bingeboy @leekahung @cameronabel @andycwilliams