Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of styled components styling & switch to MUI in ClientListTable.jsx and ClientListTableRow.jsx #219

Closed
xscottxbrownx opened this issue Jun 6, 2023 · 19 comments
Assignees
Labels
good first issue Good for newcomers refactor/optimization General label for refactoring, optimizing, or reorganizing codebase

Comments

@xscottxbrownx
Copy link
Contributor

Issue:

currently have some leftover styling in ClientListTable.jsx and ClientListTableRow.jsx from first implementation


Direction:

change to MUI components and styling instead

Screenshot 2023-06-06 at 12 59 06 PM Screenshot 2023-06-06 at 12 59 27 PM
@xscottxbrownx xscottxbrownx added enhancement Enhancement of existing features good first issue Good for newcomers refactor/optimization General label for refactoring, optimizing, or reorganizing codebase and removed enhancement Enhancement of existing features labels Jun 6, 2023
@Sky-De
Copy link

Sky-De commented Jun 7, 2023

Hi
Where are those file?
Would you please mention dir to these two .jsx file

@xscottxbrownx
Copy link
Contributor Author

Hi Where are those file? Would you please mention dir to these two .jsx file

On Development branch... src/components/Clients

@masenmatthews
Copy link
Contributor

Hey @xscottxbrownx @Sky-De , is this being worked on? If not, could I have it assigned to me? Doesn't look like I have permissions to self-assign.

@xscottxbrownx
Copy link
Contributor Author

^ Thanks andy, I missed this in email.

@andycwilliams
Copy link
Member

Hi @masenmatthews. Just checking in. Have you made progress with this?

@masenmatthews
Copy link
Contributor

Hey @andycwilliams, apologies for the delayed response! Yeah I've made some progress but have gotten a bit sidelined due to work and travel demands in the last couple of weeks. I'm out of town this week, but should be able to continue working on this next week.

If this has increased in urgency, then it might be worth reassigning if there are resources available. I should have a lot more bandwidth to work on tasks and attend meetings consistently after roughly 7/25.

@leekahung
Copy link
Contributor

Hey @masenmatthews was a bit curious as to the progress of this issue since it's related to PR #376. Let us know if you're still up to working on this issue. Thanks!

@xscottxbrownx
Copy link
Contributor Author

Unassigned, been 2.5months with no seen progress and lack of responses

@masenmatthews
Copy link
Contributor

@leekahung @xscottxbrownx
Apologies for missing your previous message. Confirming that this can be reassigned.

@andycwilliams
Copy link
Member

This is a good issue for a newer team member to take on but I can pick it up if nobody else wants to.

@leekahung
Copy link
Contributor

Think we can assign the issue to the user with an active branch working on this.

@tomdieli tomdieli self-assigned this Sep 13, 2023
@tomdieli
Copy link

I'll take a shot at this if no one else is working on it.

@andycwilliams
Copy link
Member

I'll take a shot at this if no one else is working on it.

You can but just so you know I'm currently converting ClientListTable.jsx and ClientListTableRow.jsx to MUI as part of #343. I can leave the refactoring of this styling itself to you. Just wanted to let you know in order to avoid conflicting branches.

@tomdieli
Copy link

@andycwilliams thanks for the info. I have no emotional attachment to this particular issue, and don't want to risk any unnecessary thrash. I will look for something else.

@tomdieli tomdieli removed their assignment Sep 16, 2023
bingeboy added a commit that referenced this issue Oct 4, 2023
bingeboy added a commit that referenced this issue Oct 4, 2023
…led-components-to-mui

Issue 376: Updated MUI component to used styled component
Resolves #376
Resolves #219
@milofultz
Copy link
Contributor

Would be happy to jump in on this issue to get my feet wet in the project

@milofultz milofultz self-assigned this Oct 5, 2023
@milofultz
Copy link
Contributor

I am pretty sure this issue has been solved by this PR.

Here is the commit that has the changes to the two jsx files mentioned above.

@leekahung
Copy link
Contributor

leekahung commented Oct 5, 2023

Think we can close this as complete if this is finished @xscottxbrownx or us there still other things needed?

@bingeboy
Copy link
Contributor

bingeboy commented Oct 5, 2023

Sry I thought that my comment on the PR would auto close this ticket.

@bingeboy bingeboy closed this as completed Oct 5, 2023
@xscottxbrownx
Copy link
Contributor Author

Sry I thought that my comment on the PR would auto close this ticket.

It's due to our default branch being Master, so issues won't close until code is merged into that branch...

I rose an issue for this suggesting we switch default branch to Development so issues close when PR is created to Development as is our typical flow. Issue #430

timbot1789 pushed a commit that referenced this issue Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor/optimization General label for refactoring, optimizing, or reorganizing codebase
Projects
None yet
Development

No branches or pull requests

8 participants