-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of styled components styling & switch to MUI in ClientListTable.jsx and ClientListTableRow.jsx #219
Comments
Hi |
On |
Hey @xscottxbrownx @Sky-De , is this being worked on? If not, could I have it assigned to me? Doesn't look like I have permissions to self-assign. |
^ Thanks andy, I missed this in email. |
Hi @masenmatthews. Just checking in. Have you made progress with this? |
Hey @andycwilliams, apologies for the delayed response! Yeah I've made some progress but have gotten a bit sidelined due to work and travel demands in the last couple of weeks. I'm out of town this week, but should be able to continue working on this next week. If this has increased in urgency, then it might be worth reassigning if there are resources available. I should have a lot more bandwidth to work on tasks and attend meetings consistently after roughly 7/25. |
Hey @masenmatthews was a bit curious as to the progress of this issue since it's related to PR #376. Let us know if you're still up to working on this issue. Thanks! |
Unassigned, been 2.5months with no seen progress and lack of responses |
@leekahung @xscottxbrownx |
This is a good issue for a newer team member to take on but I can pick it up if nobody else wants to. |
Think we can assign the issue to the user with an active branch working on this. |
I'll take a shot at this if no one else is working on it. |
You can but just so you know I'm currently converting |
@andycwilliams thanks for the info. I have no emotional attachment to this particular issue, and don't want to risk any unnecessary thrash. I will look for something else. |
Would be happy to jump in on this issue to get my feet wet in the project |
I am pretty sure this issue has been solved by this PR. Here is the commit that has the changes to the two |
Think we can close this as complete if this is finished @xscottxbrownx or us there still other things needed? |
Sry I thought that my comment on the PR would auto close this ticket. |
It's due to our default branch being Master, so issues won't close until code is merged into that branch... I rose an issue for this suggesting we switch default branch to Development so issues close when PR is created to Development as is our typical flow. Issue #430 |
Issue:
currently have some leftover styling in
ClientListTable.jsx
andClientListTableRow.jsx
from first implementationDirection:
change to MUI components and styling instead
The text was updated successfully, but these errors were encountered: