-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ClientListTable to optimize for mobile view #222
Comments
@xscottxbrownx has this already been addressed? When I try to reproduce the list you shared above, I get a collapsed view of If that the desired behavior, we can probably close this issue. -or- Do we want to display the full table for larger screen sizes but keep the collapsed view for smaller viewports? |
Ahhh, yes. This was an older issue, but a PR changed the fields of the table entirely which made this issue non-existent. And now, it seems we are trying to move away from tables entirely based on the latest designs from the UX team (Issue #343 and the latest in the Figma file that the UX team have been working on.) Think we are heading in more of a div/container/card fashion over tables. But to be honest, I'm not sure if this was just mobile? I know the figma file shows a table in desktop - but I think that was the UX team working with what we already had as dev team. There is a UX/UI meeting tonight, maybe we can get some clarification. |
@leekahung do you remember which PR cut out most of the table? I feel like it was one of yours somewhere. @ogorman89 I know the document table is still there and will have the "too big for mobile" issue - but again, not sure we're moving forward with tables. So may not be worth the time until we have clarification. |
It was one of the PRs when we started building the Profile page and dropping the Documents page. Don't remember the specific number |
I'm in contact with the UX team, figuring out the mobile layout vis-a-vis the desktop one. And since I'm already assigned to #343, I can also assign myself to this as well since there's a degree of overlap. |
Closing this in favor of improvements made in other PRs. If there's a UX team design that we want to implement, we can open a new ticket that links to the figma board. |
Issue:
ClientListTable
can be better optimized for mobile view. It currently gets cut off.Direction:
First thought is maybe to not display the
webId
column and instead have the name be a clickable link to the same URL.And to also not display the
Last Activity
column.The text was updated successfully, but these errors were encountered: