Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add mobile cards view to profile document list #502

Closed
Jared-Krajewski opened this issue Nov 8, 2023 · 1 comment
Closed
Labels
backlog anything that is not ready for development discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features

Comments

@Jared-Krajewski
Copy link
Contributor

Jared-Krajewski commented Nov 8, 2023

Describe the Current Behavior/Feature:

After the Table (see screenshot below of existing design) gets converted into an MUI data grid, we'll probably want a better mobile view experience for the document list.

Screenshot 2023-11-07 at 7 46 08 PM

For a while, a card design has been under discussion, see screenshot from Issue #222 (which was for contactsList, formerly clientList). However, the designs has yet to be implemented.

Screenshot 2023-08-23 at 1 28 42 PM

For the responsive breakpoint we could use the existing MUI breakpoint at theme.breakpoints.down('sm') which can be obtained by importing theme and calling const isSmallScreen = useMediaQuery(theme.breakpoints.down('sm'));.

Rationale:

While MUI data grids might look great for Desktop, it might be better to adopt a card design instead for mobile, even if it lack some of the features like sorting and filtering. But, we could always create a custom function for sorting and filtering for those cards in the future, if needed.

@Jared-Krajewski Jared-Krajewski added enhancement Enhancement of existing features backlog anything that is not ready for development discovery Open discussion and exploration of topic on hand labels Nov 8, 2023
@leekahung
Copy link
Contributor

Duplicate issue. Updated issue in #606.

@leekahung leekahung closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog anything that is not ready for development discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features
Projects
None yet
Development

No branches or pull requests

2 participants