Convert benefits to a list. #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knod
requested changes
Nov 9, 2018
There was a problem hiding this comment.
Some awesome work here!
One note I couldn't add is that the updateClientValue needs to be changed too. The way it's setting shelter and housing stuff is weird and this messes it up. You'll see when you look at it. Let me know if you need another eye on it since it's a bit wacky. Generally searching the code for hasSNAP and hasSection8 will probably reveal any stray problems.
Other than those two things, I think we're good...
|
Btw, that's the kind of problem I think figuring out #952 would help. |
knod
reviewed
Nov 11, 2018
knod
approved these changes
Nov 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964