Skip to content

⚡️ Speed up function _check_values_are_feasible by 38% #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function _check_values_are_feasible by 38% #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions optuna/study/_tell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,18 @@ def _check_state_and_values(


def _check_values_are_feasible(study: Study, values: Sequence[float]) -> str | None:
float_cast = float
isnan = math.isnan

for v in values:
# TODO(Imamura): Construct error message taking into account all values and do not early
# return `value` is assumed to be ignored on failure so we can set it to any value.
try:
float(v)
float_cast(v)
except (ValueError, TypeError):
return f"The value {repr(v)} could not be cast to float"

if math.isnan(v):
if isnan(v):
return f"The value {v} is not acceptable"

if len(study.directions) != len(values):
Expand Down