Skip to content

⚡️ Speed up method JournalStorageReplayResult._apply_create_study by 22% #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method JournalStorageReplayResult._apply_create_study by 22% #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions optuna/storages/journal/_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,15 +490,19 @@ def _apply_create_study(self, log: dict[str, Any]) -> None:
study_name = log["study_name"]
directions = [StudyDirection(d) for d in log["directions"]]

if study_name in [s.study_name for s in self._studies.values()]:
if self._is_issued_by_this_worker(log):
raise DuplicatedStudyError(
"Another study with name '{}' already exists. "
"Please specify a different name, or reuse the existing one "
"by setting `load_if_exists` (for Python API) or "
"`--skip-if-exists` flag (for CLI).".format(study_name)
)
return
# Optimize for checking duplicate study name by avoiding list comprehension
# Build a set of current study names for O(1) lookup if studies exist
if self._studies:
study_names = set(s.study_name for s in self._studies.values())
if study_name in study_names:
if self._is_issued_by_this_worker(log):
raise DuplicatedStudyError(
"Another study with name '{}' already exists. "
"Please specify a different name, or reuse the existing one "
"by setting `load_if_exists` (for Python API) or "
"`--skip-if-exists` flag (for CLI).".format(study_name)
)
return

study_id = self._next_study_id
self._next_study_id += 1
Expand Down