Skip to content

⚡️ Speed up function load_color by 14% #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function load_color by 14% #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 34 additions & 11 deletions gradio/themes/builder_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,9 +663,11 @@ def generate_theme_code(
)
):
font_diffs[font_set_name] = [
f"gr.themes.GoogleFont('{font_name}')"
if is_google_font
else f"'{font_name}'"
(
f"gr.themes.GoogleFont('{font_name}')"
if is_google_font
else f"'{font_name}'"
)
for font_name, is_google_font in theme_font_set
]

Expand Down Expand Up @@ -730,40 +732,56 @@ def render_variables(history, base_theme, *args):
3 + 3 * len(palette_range) : 6 + 3 * len(palette_range)
]
text_sizes = args[
6 + 3 * len(palette_range) : 6
6
+ 3 * len(palette_range) : 6
+ 3 * len(palette_range)
+ len(size_range)
]
spacing_sizes = args[
6 + 3 * len(palette_range) + len(size_range) : 6
6
+ 3 * len(palette_range)
+ len(size_range) : 6
+ 3 * len(palette_range)
+ 2 * len(size_range)
]
radius_sizes = args[
6 + 3 * len(palette_range) + 2 * len(size_range) : 6
6
+ 3 * len(palette_range)
+ 2 * len(size_range) : 6
+ 3 * len(palette_range)
+ 3 * len(size_range)
]
main_fonts = args[
6 + 3 * len(palette_range) + 3 * len(size_range) : 6
6
+ 3 * len(palette_range)
+ 3 * len(size_range) : 6
+ 3 * len(palette_range)
+ 3 * len(size_range)
+ 4
]
main_is_google = args[
6 + 3 * len(palette_range) + 3 * len(size_range) + 4 : 6
6
+ 3 * len(palette_range)
+ 3 * len(size_range)
+ 4 : 6
+ 3 * len(palette_range)
+ 3 * len(size_range)
+ 8
]
mono_fonts = args[
6 + 3 * len(palette_range) + 3 * len(size_range) + 8 : 6
6
+ 3 * len(palette_range)
+ 3 * len(size_range)
+ 8 : 6
+ 3 * len(palette_range)
+ 3 * len(size_range)
+ 12
]
mono_is_google = args[
6 + 3 * len(palette_range) + 3 * len(size_range) + 12 : 6
6
+ 3 * len(palette_range)
+ 3 * len(size_range)
+ 12 : 6
+ 3 * len(palette_range)
+ 3 * len(size_range)
+ 16
Expand Down Expand Up @@ -870,7 +888,12 @@ def attach_rerender(evt_listener):
)

def load_color(color_name):
color = [color for color in colors if color.name == color_name][0]
# Optimize lookup: use next() instead of list comprehension for early exit
color = next((color for color in colors if color.name == color_name), None)
# This will still raise an IndexError if not found, preserving behavior
if color is None:
raise IndexError("list index out of range")
# Optimize palette building with list comprehension outside of getattr string formatting
return [getattr(color, f"c{i}") for i in palette_range]

attach_rerender(
Expand Down