Skip to content

showing a loading Spinner on first page load #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/lib/components/AuthLoading.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<script lang="ts">
import { getFirebaseContext } from "../stores/sdk.js";
import { userStore } from "../stores/auth.js";
const auth = getFirebaseContext().auth!;
const user = userStore(auth);
</script>

{#if $user === undefined}
<slot {auth}>Loading...</slot>
{/if}
4 changes: 2 additions & 2 deletions src/lib/components/SignedOut.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@

</script>

{#if !$user}
{#if $user === null}
<slot {auth} />
{/if}
{/if}
28 changes: 15 additions & 13 deletions src/lib/stores/auth.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
import { writable } from "svelte/store";
import { getFirebaseContext } from "./sdk.js";
import { onAuthStateChanged, type Auth } from "firebase/auth";
import { readable, writable } from "svelte/store";
import { onAuthStateChanged, type Auth, type User } from "firebase/auth";

/**
* @param {Auth} auth firebase auth instance
* @param {any} startWith optional default data. Useful for server-side cookie-based auth
* @returns a store with the current firebase user
* user != null -> signed in
* user == null -> signed out
* user == undefined -> still loading auth status on initial page load -> show loading spinner or sth else to prevent a normally signed in user from seeing content as a signed out user for a second
*/
export function userStore(auth: Auth, startWith = null) {
export function userStore(auth: Auth, startWith = undefined) {
let unsubscribe: () => void;

// Fallback for SSR
if (!globalThis.window) {
const { subscribe } = writable(startWith);
const { subscribe } = readable(startWith);
return {
subscribe,
};
Expand All @@ -23,19 +25,19 @@ export function userStore(auth: Auth, startWith = null) {
console.warn(
"Firebase Auth is not initialized. Are you missing FirebaseApp as a parent component?"
);
const { subscribe } = writable(null);
const { subscribe } = readable(undefined);
return {
subscribe,
};
}

const { subscribe } = writable(auth?.currentUser ?? null, (set) => {
unsubscribe = onAuthStateChanged(auth, (user) => {
set(user);
});

return () => unsubscribe();
});
const { subscribe } = readable<User | null | undefined>(
auth.currentUser ?? undefined,
(set) => {
const unsubscribe = onAuthStateChanged(auth, set);
return () => unsubscribe();
}
);

return {
subscribe,
Expand Down
7 changes: 6 additions & 1 deletion src/routes/auth-test/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import SignedIn from '$lib/components/SignedIn.svelte';
import SignedOut from '$lib/components/SignedOut.svelte';
import { signInAnonymously } from "firebase/auth";

import AuthLoading from "$lib/components/AuthLoading.svelte";

</script>

Expand All @@ -18,3 +18,8 @@
<h2>Signed Out</h2>
<button on:click={() => signInAnonymously(auth)}>Sign In</button>
</SignedOut>

<AuthLoading>
<h2>Checking Auth</h2>
<p>Loading...</p>
</AuthLoading>