Add (incomplete) base/pass fixture #109
Conversation
- Introduced a new Makefile target `record_fixtures` to facilitate recording test fixtures. - Added a new test case for the `pass_all` stage in `stages_test.go`, enhancing test coverage. - Created a new fixture file for the `pass_all` stage to support the new test case.
|
Warning Rate limit exceeded@andy1li has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 25 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
""" WalkthroughA new Makefile target for recording fixtures was introduced, and an environment variable in an existing test target was renamed. A new test case named "pass_all" was added to the test suite, referencing a newly created test fixture file containing detailed output for multiple test scenarios involving SQLite3 commands and database inspection. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
- Modified the `StageSlugs` in the `pass_all` test case to exclude certain slugs due to SQLite3 limitations on Linux. - Ensured the test remains functional while adhering to the constraints of the environment.
- Replaced existing test cases for various stages with new queries and structures to enhance testing coverage. - Added new test cases for stages #SZ4, #ND9, and #VC9, including database creation and data retrieval. - Removed outdated test cases for stages #NZ8, #WS9, and #RF3, ensuring the fixture aligns with current testing requirements.
- Removed outdated stage slugs from the `pass_all` test case to address randomness issues. - Updated the pass fixture to reflect new queries and data for stages #WS9 and #NZ8, enhancing test coverage and accuracy.
| "pass_all": { | ||
| // omitted "dr6", "ce0" because sqlite3 on linux is not compiled to support .dbinfo | ||
| // omitted "az9", "vc9", "rf3" because of randomness issues | ||
| StageSlugs: []string{"sz4", "nd9", "ws9", "nz8"}, |
There was a problem hiding this comment.
@andy1li what's the context here and the reason for this PR? If we're adding this I think we should solve the problems mentioned above re: randomness and .dbinfo support not being available.
There was a problem hiding this comment.
Ah, it's part of my investigation on the timing-out issue in the last "index" stage. The main purpose of this PR was to determine if the issue would happen in GH actions. Result: it did not time out here.
Will try and resolve the problems mentioned in the comment.
There was a problem hiding this comment.
Ah, okay - yeah if it's easy to do feel free to, if not no problem we'll get to it when we're working on SQLite next
Summary by CodeRabbit
New Features
Chores