Refactor MultiLineAssertions to use SingleLineAssertions internally #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced SingleLineAssertions to allow for more granular assertions. - Added NewMultiLineAssertion and NewEmptyMultiLineAssertion constructors. - Implemented AddSingleLineAssertion method for adding single line assertions with fallback patterns. - Updated Inspect and Run methods to accommodate the new structure.
- Removed ExpectedOutput and FallbackPatterns fields. - Introduced MultiLineAssertion field to streamline assertion handling. - Updated Run method to utilize the new MultiLineAssertion structure.
- Replaced ExpectedOutput and FallbackPatterns with MultiLineAssertion in CommandWithMultilineResponseTestCase for stages R1 and R3. - Enhanced test case structure for improved assertion handling and consistency across tests.
- Updated testR4 function to utilize MultiLineAssertion for error message validation. - Replaced ExpectedOutput and FallbackPatterns with a more structured approach using AddSingleLineAssertion. - Improved regex handling for error messages to ensure accurate assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant refactoring and enhancements to the multi-line assertion functionality within the codebase. The changes mainly focus on replacing the old method of handling multi-line assertions with a more structured and flexible approach. Additionally, some minor improvements and cleanups are included.
Refactoring and Enhancements:
internal/assertions/multi_line_assertion.go: Replaced theExpectedOutputandFallbackPatternsfields with aSingleLineAssertionsslice. Added methods to construct and manipulate multi-line assertions, includingNewMultiLineAssertion,NewEmptyMultiLineAssertion,AddSingleLineAssertion, and updatedRunmethod to handle the new structure.internal/stage_r1.go: Updated thetestR1function to use the newMultiLineAssertionconstructor for multi-line test cases. [1] [2]internal/stage_r3.go: Updated thetestR3function to use the newMultiLineAssertionconstructor for multi-line test cases. [1] [2] [3] [4]internal/stage_r4.go: Enhanced thetestR4function to use the newMultiLineAssertionstructure, including handling regex patterns for error messages.Minor Improvements:
internal/test_cases/command_reflection_test_case.goandinternal/test_cases/command_response_test_case.go: Modified theRunmethod to use formatted strings for success messages. [1] [2]internal/test_cases/command_with_multiline_response_test_case.go: Updated theCommandWithMultilineResponseTestCasestruct to use the newMultiLineAssertionfield and modified theRunmethod accordingly. [1] [2] [3]