update failure case #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in the diff include refactoring the shell_executable package in the condition_reader/condition_reader.go file. The ReadBytesUntil and ReadBytesUntilTimeout methods now wrap the reader error to handle program exit errors properly. In the stage4.go file, the error handling for program exit in the testExit function has been updated to check for the ErrProgramExited error instead of specific error types. Additionally, there is a change in the fixtures/missing_command/wrong_output file, which shows that the program exited instead of reaching EOF. Commit message: "Refactor shell_executable package and fix error handling in stage4.go"
|
@ryan-gang tagging you for a post-merge review - merging since I want to use this when testing the challenge |
ryan-gang
reviewed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.