Refactor RealDecoder for improved error handling and code readability #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced direct byte manipulation with GetInt32 method for better abstraction and error handling. - Enhanced error messages by adding context to decoding errors. - Improved readability and maintainability of GetArrayLength, GetCompactInt32Array, and GetInt32Array methods.
…rror handling and readability - Replaced direct byte manipulation with GetInt32 method to abstract away complexity and improve error handling. - Added context to decoding errors for better debugging. - Enhanced readability and maintainability of the GetArrayLength function.
- Replaced direct byte manipulation with a call to GetInt64 for improved abstraction. - Added context to decoding errors to aid in debugging. - Improved overall readability and maintainability of the GetInt64Array function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several refactorings in the RealDecoder class to enhance error handling and improve code readability. The commits in this pull request replace direct byte manipulation with appropriate method calls to abstract away complexity and improve error handling. Error messages have been enhanced by adding context to decoding errors, aiding in debugging. Additionally, the readability and maintainability of the GetArrayLength, GetCompactInt32Array, GetInt32Array, and GetInt64Array methods have been improved. These changes contribute to a more robust and maintainable RealDecoder implementation.