Finish generating LogDirectory before booting up any executable #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odedCorrelationId function - Replaced instances of logger with stageLogger for consistent logging. - Enhanced error handling by ensuring proper closure of the broker. - Streamlined log messages for better clarity and maintainability.
…ction - Replaced instances of logger with stageLogger for consistent logging. - Improved error handling by ensuring proper closure of the broker. - Streamlined log messages for better clarity and maintainability.
… function - Replaced instances of logger with stageLogger for consistent logging throughout the function. - Improved error handling by ensuring proper closure of the broker using a deferred function. - Streamlined log messages for better clarity and maintainability.
- Replaced instances of logger with stageLogger for consistent logging throughout the function. - Improved error handling by ensuring proper closure of the broker using a deferred function. - Streamlined log messages for better clarity and maintainability.
…s function - Replaced instances of logger with stageLogger for consistent logging throughout the function. - Improved error handling by ensuring proper closure of the broker using a deferred function. - Streamlined log messages for better clarity and maintainability.
…function - Replaced instances of logger with stageLogger for consistent logging throughout the function. - Improved error handling by ensuring proper closure of clients using a deferred function. - Streamlined log messages for better clarity and maintainability.
…Key function - Replaced instances of logger with stageLogger for consistent logging throughout the function. - Improved error handling by ensuring proper closure of the broker using a deferred function. - Streamlined log messages for better clarity and maintainability.
…unction - Replaced instances of logger with stageLogger for consistent logging throughout the function. - Improved error handling by ensuring proper closure of the broker using a deferred function. - Streamlined log messages for better clarity and maintainability.
…icID function - Replaced instances of logger with stageLogger for consistent logging throughout the function. - Improved error handling by ensuring proper closure of the broker using a deferred function. - Streamlined log messages for better clarity and maintainability.
…unction - Replaced instances of logger with stageLogger for consistent logging throughout the function. - Improved error handling by ensuring proper closure of the broker using a deferred function. - Streamlined the execution flow by moving the broker run check to a more logical position.
- Replaced instances of logger with stageLogger for consistent logging throughout the test functions. - Improved error handling by ensuring proper closure of the broker using a deferred function. - Streamlined log messages for better clarity and maintainability across testAPIVersionWithDescribeTopicPartitions, testDTPartitionWithUnknownTopic, testDTPartitionWithTopicAndSinglePartition, testDTPartitionWithTopicAndMultiplePartitions2, and testDTPartitionWithTopics functions.
|
Thanks @harveysanders for highlighting the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several changes to improve the logging consistency across multiple stages of the Kafka tester. The primary change is the replacement of the
loggervariable withstageLoggerin various functions to ensure that the correct logger instance is used throughout the stages.Improvements to logging consistency:
internal/stage1.go: ReplacedloggerwithstageLoggerin thetestBindToPortfunction to ensure consistent logging. [1] [2]internal/stage2.go: Updated thetestHardcodedCorrelationIdfunction to usestageLoggerinstead ofloggerfor all logging operations. [1] [2] [3] [4] [5]internal/stage3.go: Modified thetestCorrelationIdfunction to usestageLoggerfor logging, ensuring consistency. [1] [2] [3] [4] [5] [6]internal/stage4.go: Updated thetestAPIVersionErrorCasefunction to usestageLoggerfor all logging activities. [1] [2] [3] [4] [5] [6]internal/stage5.go: Ensured that thetestAPIVersionfunction usesstageLoggerfor consistent logging. [1] [2]internal/stagec1.go: Changed thetestSequentialRequestsfunction to usestageLoggerinstead ofloggerfor logging.