Refactor fetch response assertions and tests #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the fetch response assertions and tests to improve code readability and maintainability. It includes the following changes:
Added minimal FetchResponseAssertion for testing fetch responses
Added assertions for recordBatch + Records in FetchResponseAssertion
Improved error code logging in FetchResponseAssertion
Utilized FetchResponseAssertion in f4
Removed custom checks in f4, f2, and f3
Added AssertNoTopics method to FetchResponseAssertion
Called AssertNoTopics method in f2
Updated error code string issue
Added more error codes to mapping
Updated testFetchNoMessages function in f4
Added testFetchWithSingleMessage function in f5
Added testFetchWithMultiMessages function in f6
Set up tester prerequisites
These changes enhance the fetch response assertions and tests, making them more robust and easier to maintain.