[sqlite] CC-1935: Upgrade Zig to v0.15 #144
Conversation
- Changed minimum Zig version from 0.14.0 to 0.15.1 in build.zig.zon and codecrafters.yml files. - Updated build.zig to use `createModule` for the executable's root module. - Modified README.md and config.yml to reflect the new required Zig version. - Adjusted script execution in run.sh and your_program.sh for better compatibility. - Enhanced stdout handling in main.zig for improved output management.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if (args.len < 3) { | ||
| try std.io.getStdErr().writer().print("Usage: {s} <database_file_path> <command>\n", .{args[0]}); | ||
| try stdout.print("Usage: {s} <database_file_path> <command>\n", .{args[0]}); | ||
| try stdout.flush(); |
There was a problem hiding this comment.
Bug: Invalid API Usage Causes Compilation Errors
The stdout_writer initialization uses an invalid Zig API (std.fs.File.stdout().writer(&buffer).interface), which will cause compilation errors. This change also redirects usage error messages from stderr to stdout, which goes against standard Unix conventions.
Additional Locations (2)
| if (args.len < 3) { | ||
| try std.io.getStdErr().writer().print("Usage: {s} <database_file_path> <command>\n", .{args[0]}); | ||
| try stdout.print("Usage: {s} <database_file_path> <command>\n", .{args[0]}); | ||
| try stdout.flush(); |
There was a problem hiding this comment.
Bug: Unix Conventions Violated: Error Messages Redirected
Usage error messages are now printed to stdout instead of stderr. This change breaks standard Unix conventions for command-line tools, affecting script handling and output redirection.
Additional Locations (1)
| .root_module = b.createModule(.{ | ||
| .root_source_file = b.path("src/main.zig"), | ||
| .target = b.graph.host, | ||
| }), |
There was a problem hiding this comment.
Bug: Build Configuration Locks Target and Optimization
The build.zig configuration hardcodes the build target to b.graph.host and removes the optimization option. This change eliminates the ability to cross-compile or specify optimization levels via zig build command-line arguments, reducing build flexibility.
Additional Locations (1)
No description provided.