Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace leftover words redis with kafka #4

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Replace leftover words redis with kafka #4

merged 2 commits into from
Sep 17, 2024

Conversation

andy1li
Copy link
Member

@andy1li andy1li commented Sep 17, 2024 •
edited
Loading

Thanks @ElijahElrod for highlighting this! Help Scout #5405

And props to @jessevanassen for submitting a PR to fix the issue.

@andy1li andy1li requested a review from ryan-gang September 17, 2024 06:23
@andy1li andy1li self-assigned this Sep 17, 2024
ryan-gang
ryan-gang approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ryan-gang ryan-gang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great, Time to Merge!

@andy1li andy1li merged commit 0501646 into main Sep 17, 2024
15 checks passed
@andy1li andy1li mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-gang ryan-gang ryan-gang approved these changes

Assignees

@andy1li andy1li

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy1li @ryan-gang