Skip to content

Update stage 3 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Update stage 3 #13

merged 2 commits into from
Oct 12, 2024

Conversation

vic-ma
Copy link
Contributor

@vic-ma vic-ma commented Oct 8, 2024

No description provided.


The format of the request header is as follows:
To get the correlation ID, you need to find its offset. You already know that the message size is 4 bytes long. And here's what the request header looks like (in this challenge, we're using [request header v2](https://kafka.apache.org/protocol.html#protocol_messages)):
Copy link
Contributor Author

@vic-ma vic-ma Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in this challenge, we're using [request header v2]

Should this also be changed to "In this stage," as per this comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitpaulk done!

@vic-ma
Copy link
Contributor Author

vic-ma commented Oct 8, 2024

@rohitpaulk Ready for review

@rohitpaulk rohitpaulk merged commit 176568d into codecrafters-io:main Oct 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants