-
Notifications
You must be signed in to change notification settings - Fork 24
[HTTP] Add notes related to anti-cheat tests #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added notes in the course definition emphasizing that the HTTP server must be implemented from scratch using TCP primitives, prohibiting the use of built-in HTTP libraries. - Updated relevant stages to reinforce this requirement, ensuring learners understand the constraints of the challenge.
Caution Review failedThe pull request is closed. WalkthroughThe pull request updates the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
course-definition.yml (1)
44-45
: Clear Global Requirement Note:
The newly added note at line 44 effectively emphasizes that participants must implement the HTTP server from scratch using TCP primitives and must not use built-in HTTP libraries—a key anti-cheat measure.Consider unifying note styles by, for example, prefixing this global note with a markdown header (e.g.,
### Important:
) to match the formatting used elsewhere in the document.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
course-definition.yml
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: test_course_definition / test (kotlin)
- GitHub Check: test_course_definition / test (haskell)
- GitHub Check: test_course_definition / test (cpp)
🔇 Additional comments (1)
course-definition.yml (1)
191-193
: Stage-Specific Reminder Consistency:
The note added at line 191 reinforces the global requirement in the context of the "Bind to a port" stage, reminding participants not to use built-in HTTP libraries. This redundancy helps ensure that the requirement is front and center at a critical point in the course workflow.Optionally, you may consider if the similar reminders across the global description and this stage could be consolidated to reduce repetition, or if the current approach better underscores the importance of the rule.
- Revised the course description to specify that the HTTP server must be built from scratch using TCP primitives. - Updated notes in the stages to emphasize the prohibition of built-in HTTP libraries and provide additional resources for understanding HTTP responses.
Summary by CodeRabbit