Skip to content

Conversation

@benregn
Copy link

@benregn benregn commented Mar 19, 2024

Closes #1238 🙌

@benregn benregn requested a review from a team as a code owner March 19, 2024 08:02
@benregn benregn force-pushed the 1238-ci-support-semaphore-ci branch from 2270741 to 82e616e Compare March 19, 2024 08:32
@codecov
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.61%. Comparing base (308e747) to head (14c7232).
⚠️ Report is 391 commits behind head on main.

Files with missing lines Patch % Lines
src/ci_providers/provider_semaphore.ts 94.44% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   92.78%   92.61%   -0.17%     
==========================================
  Files          36       37       +1     
  Lines        1358     1395      +37     
  Branches      273      281       +8     
==========================================
+ Hits         1260     1292      +32     
- Misses         68       72       +4     
- Partials       30       31       +1     
Flag Coverage Δ
aarch64 92.61% <94.59%> (+0.05%) ⬆️
aarch64-without-git 92.61% <94.59%> (+0.05%) ⬆️
alpine 92.61% <94.59%> (-0.17%) ⬇️
alpine-proxy 92.61% <94.59%> (+0.05%) ⬆️
alpine-without-git 92.61% <94.59%> (-0.17%) ⬇️
linux 92.61% <94.59%> (+0.05%) ⬆️
linux-without-git 92.61% <94.59%> (+0.05%) ⬆️
macos 92.61% <94.59%> (+0.05%) ⬆️
macos-without-git 92.61% <94.59%> (+0.05%) ⬆️
windows 92.61% <94.59%> (-0.17%) ⬇️
windows-without-git ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ci_providers/index.ts 100.00% <100.00%> (ø)
src/ci_providers/provider_semaphore.ts 94.44% <94.44%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @benregn! Just some changes. Do you also have a semaphore CI run to run this off of?

@benregn benregn force-pushed the 1238-ci-support-semaphore-ci branch from 82e616e to 14c7232 Compare March 23, 2024 12:29
@benregn
Copy link
Author

benregn commented Mar 23, 2024

@thomasrockhu-codecov Thank you for the feedback! Overlooked that those lines weren't needed anymore 🤦

We're using Semaphore at my place of work.

@benregn
Copy link
Author

benregn commented May 23, 2024

@thomasrockhu-codecov ping 🙂

@thomasrockhu-codecov thomasrockhu-codecov removed their request for review September 19, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Support: SemaphoreCI

2 participants