show files for all versions if no version given for fetch command

Author: Gisonrg

Symfony/src/Codebender/LibraryBundle/Entity/Library.php

@@ -469,4 +469,26 @@ public function getVersions()
     {
         return $this->versions;
     }
+
+    /**
+     * Get the metadata of the library
+     *
+     * @return array
+     */
+    public function getLiraryMeta()
+    {
+        return array(
+            'name' => $this->getName(),
+            'description' => $this->getDescription(),
+            'verified' => $this->getVerified(),
+            'gitOwner' => $this->getOwner(),
+            'gitRepo' => $this->getRepo(),
+            'url' => $this->getUrl(),
+            'active' => $this->getActive(),
+            'gitBranch' => $this->getBranch(),
+            'gitLastCommit' => $this->getLastCommit(),
+            'gitInRepoPath' => $this->getInRepoPath(),
+            'libraryNotes' => $this->getNotes()
+        );
+    }
 }

Symfony/src/Codebender/LibraryBundle/Handler/ApiCommand/FetchApiCommand.php

@@ -2,6 +2,7 @@
 
 namespace Codebender\LibraryBundle\Handler\ApiCommand;
 
+use Codebender\LibraryBundle\Entity\Version;
 use Symfony\Component\Finder\Finder;
 
 class FetchApiCommand extends AbstractApiCommand
@@ -11,9 +12,9 @@ public function execute($content)
         $content = $this->setDefault($content);
         $filename = $content['library'];
 
-        $last_slash = strrpos($content['library'], "/");
+        $last_slash = strrpos($filename, "/");
         if ($last_slash !== false) {
-            $filename = substr($content['library'], $last_slash + 1);
+            $filename = substr($filename, $last_slash + 1);
         }
 
         $apiHandler = $this->container->get('codebender_library.apiHandler');
@@ -37,24 +38,66 @@ public function execute($content)
             if ($content['renderView']) {
                 $examples = $this->fetchLibraryExamples($exampleFinder, $builtinLibrariesPath . "/libraries/" . $filename);
                 $meta = [];
+                $versions = [];
             }
         } else {
             if (!$apiHandler->isExternalLibrary($filename, $content['disabled'])) {
                 return ["success" => false, "message" => "No Library named " . $filename . " found."];
             }
 
-            $response = $this->fetchLibraryFiles($finder, $externalLibrariesPath . "/" . $filename . "/" . $content['version']);
-            if (empty($response)) {
-                return ['success' => false, 'message' => 'No files for Library named `' . $filename . '` with version `' . $content['version'] . '` found.'];
+            // check if requested (if any) version is valid
+            if ($content['version'] !== null && !$apiHandler->libraryVersionExists($filename, $content['version'])) {
+                return [
+                    'success' => false,
+                    'message' => 'No files for Library named `' . $filename . '` with version `' . $content['version'] . '` found.'
+                ];
             }
 
-            if ($content['renderView']) {
-                $examples = $this->fetchLibraryExamples($exampleFinder, $externalLibrariesPath . "/" . $filename . "/" . $content['version']);
+            $versionObjects = $apiHandler->getAllVersionsFromDefaultHeader($filename);
+
+            // use the requested version (if any) for fetching data
+            // else fetch data for all versions
+            $versions = $versionObjects->toArray();
+            if ($content['version'] !== null) {
+                $versionsCollection = $versionObjects->filter(function ($version) use ($content) {
+                    return $version->getVersion() === $content['version'];
+                });
+                $versions = $versionsCollection->toArray();
+            }
+
+            // fetch library files for each version
+            $response = [];
+            $examples = [];
+            foreach ($versions as $version) {
+                /* @var Version $version */
+                $libraryPath = $externalLibrariesPath . "/" . $filename . "/" . $version->getFolderName();
+
+                // fetch library files for this version
+                $fetchResponse = $this->fetchLibraryFiles($finder->create(), $libraryPath);
+                if (!empty($fetchResponse)) {
+                    $response[$version->getVersion()] = $fetchResponse;
+                }
 
-                $externalLibrary = $this->entityManager->getRepository('CodebenderLibraryBundle:ExternalLibrary')
-                    ->findOneBy(array('machineName' => $filename));
-                $filename = $externalLibrary->getMachineName();
+                if ($content['renderView']) {
+                    // fetch example files for this version if it's rendering view
+                    $exampleResponse = $this->fetchLibraryExamples($exampleFinder->create(), $libraryPath);
+                    if (!empty($exampleResponse)) {
+                        $examples[$version->getVersion()] = $exampleResponse;
+                    }
+                }
+            }
+
+            if ($content['renderView']) {
+                $externalLibrary = $this->entityManager->getRepository('CodebenderLibraryBundle:Library')
+                    ->findOneBy(array('default_header' => $filename));
+                $filename = $externalLibrary->getDefaultHeader();
                 $meta = $externalLibrary->getLiraryMeta();
+                $versions = array_map(
+                    function ($version) {
+                        return $version->getVersion();
+                    },
+                    $versions
+                );
             }
         }
 
@@ -65,6 +108,7 @@ public function execute($content)
         return [
             'success' => true,
             'library' => $filename,
+            'versions' => $versions,
             'files' => $response,
             'examples' => $examples,
             'meta' => $meta
@@ -84,9 +128,9 @@ private function fetchLibraryFiles($finder, $directory, $getContent = true)
         if (!is_dir($directory)) {
             return array();
         }
-
         $finder->in($directory)->exclude('examples')->exclude('Examples');
         $finder->name('*.*');
+        $finder->files(); // fetch only files
 
         $finfo = finfo_open(FILEINFO_MIME_TYPE);
 

Symfony/src/Codebender/LibraryBundle/Tests/Controller/ApiControllerTest.php

@@ -369,7 +369,9 @@ public function testFetchApiCommand()
         $this->assertTrue($response['success']);
         $this->assertEquals('Library found', $response['message']);
 
-        $filenames = array_column($response['files'], 'filename');
+        $this->assertArrayHasKey('1.1.0', $response['files']);
+
+        $filenames = array_column($response['files']['1.1.0'], 'filename');
         $this->assertContains('default.cpp', $filenames);
         $this->assertContains('default.h', $filenames);
         $this->assertContains('inc_file.inc', $filenames);