consider if a library is disabled when checking external library

Author: Gisonrg

Symfony/src/Codebender/LibraryBundle/Handler/ApiCommand/FetchApiCommand.php

@@ -9,6 +9,12 @@ class FetchApiCommand extends AbstractApiCommand
     public function execute($content)
     {
         $content = $this->setDefault($content);
+        $filename = $content['library'];
+
+        $last_slash = strrpos($content['library'], "/");
+        if ($last_slash !== false) {
+            $filename = substr($content['library'], $last_slash + 1);
+        }
 
         $apiHandler = $this->container->get('codebender_library.apiHandler');
 
@@ -18,13 +24,6 @@ public function execute($content)
         $finder = new Finder();
         $exampleFinder = new Finder();
 
-        $filename = $content['library'];
-
-        $last_slash = strrpos($content['library'], "/");
-        if ($last_slash !== false) {
-            $filename = substr($content['library'], $last_slash + 1);
-        }
-
         //TODO handle the case of different .h filenames and folder names
         $reservedNames = ["ArduinoRobot" => "Robot_Control", "ArduinoRobotMotorBoard" => "Robot_Motor",
             "BlynkSimpleSerial" => "BlynkSimpleEthernet", "BlynkSimpleCC3000" => "BlynkSimpleEthernet"];
@@ -40,7 +39,7 @@ public function execute($content)
                 $meta = [];
             }
         } else {
-            if (!$apiHandler->isExternalLibrary($filename)) {
+            if (!$apiHandler->isExternalLibrary($filename, $content['disabled'])) {
                 return ["success" => false, "message" => "No Library named " . $filename . " found."];
             }
 
@@ -74,6 +73,7 @@ public function execute($content)
 
     private function setDefault($content)
     {
+        $content['disabled'] = (array_key_exists('disabled', $content) ? $content['disabled'] : false);
         $content['version'] = (array_key_exists('version', $content) ? $content['version'] : null);
         $content['renderView'] = (array_key_exists('renderView', $content) ? $content['renderView'] : false);
         return $content;

Symfony/src/Codebender/LibraryBundle/Handler/ApiHandler.php

@@ -137,11 +137,14 @@ public function isBuiltInLibraryExample($defaultHeader)
      * This method checks if a given external library exists in the database.
      *
      * @param $defaultHeader
+     * @param bool $getDisabled
      * @return bool
      */
-    public function isExternalLibrary($defaultHeader)
+    public function isExternalLibrary($defaultHeader, $getDisabled = false)
     {
-        return $this->getLibraryFromDefaultHeader($defaultHeader) !== null;
+        $library = $this->getLibraryFromDefaultHeader($defaultHeader);
+
+        return $getDisabled ? $library !== null : $library !== null && $library->getActive();
     }
 
     /**