fix(config): load lsp config from jsonc configuration files#1765
Open
COLDTURNIP wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix(config): load lsp config from jsonc configuration files#1765COLDTURNIP wants to merge 1 commit intocode-yeongyu:devfrom
COLDTURNIP wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Documentation-only changes adding .jsonc support with comprehensive tests. All changes are additive (backward compatible), tests verify new functionality works correctly. No logic regressions possible
Signed-off-by: Raphanus Lo <[email protected]>
391c8f7 to
f80b72c
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The LSP server config loader currently hardcodes
.jsonfilenames, so JSONC-only configs (e.g.opencode.jsonc,oh-my-opencode.jsonc) are not discovered. Reuses the existingdetectConfigFile()helper (already used by the main plugin config loader) insidesrc/tools/lsp/server-config-loader.ts:getConfigPaths()so LSP config discovery prefers.jsoncand falls back to.json.Changes
Code: LSP config path discovery uses
detectConfigFile()for project/user/opencode config filesTests: regression coverage for JSONC-only filename lookup and
.jsoncprecedenceDocs: clarify that
.jsoncpriority applies to LSP tool config discovery tooTesting
src/tools/lsp/server-config-loader.test.tsRelated Issues
#1763
Summary by cubic
Fixes LSP server config discovery to load .jsonc files and prefer them over .json. Prevents missing configs when projects use JSONC-only files and keeps LSP discovery consistent with the main config loader.
Written for commit f80b72c. Summary will update on new commits.