test(session-manager): add positive-path tests for todos and transcript#1741
Open
danpung2 wants to merge 1 commit intocode-yeongyu:devfrom
Open
test(session-manager): add positive-path tests for todos and transcript#1741danpung2 wants to merge 1 commit intocode-yeongyu:devfrom
danpung2 wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Cannot be 100% sure no regressions. The PR adds readSessionTranscript to imports but no implementation is shown in the diff - risk of undefined function. Also, new test expects lineCount=4 but logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
readSessionTodoshappy-path test using a session-matching todo JSON filereadSessionTranscripthappy-path test counting non-empty lines in.jsonlTesting
bun run typecheck bun testSummary by cubic
Add happy-path tests for session-manager storage to verify todo parsing and transcript line counting.
Covers readSessionTodos mapping from a matching JSON file and readSessionTranscript returning the count of non-empty lines in .jsonl.
Written for commit 6a050a3. Summary will update on new commits.