fix(call-omo-agent): enforce disabled_agents config#1729
Open
potb wants to merge 2 commits intocode-yeongyu:devfrom
Open
fix(call-omo-agent): enforce disabled_agents config#1729potb wants to merge 2 commits intocode-yeongyu:devfrom
potb wants to merge 2 commits intocode-yeongyu:devfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Cannot be 100% sure of no regressions. Dependency bump from 3.3.1 to 3.5.0 is a minor version jump with unknown breaking changes. Native binary deps require runtime testing across all platforms (darwn
potb
force-pushed
the
fix/1716-disabled-agents-call-omo
branch
from
072a4f9 to
5011935
Compare
Closes code-yeongyu#1716 ## Summary - Added 4 tests for disabled_agents validation in call_omo_agent tool - Tests verify agent rejection when in disabled_agents list - Tests verify case-insensitive matching - Tests verify agents not in disabled list are allowed - Tests verify empty disabled_agents allows all agents
## Summary - Added disabled_agents parameter to createCallOmoAgent factory - Check runs after ALLOWED_AGENTS validation, before agent execution - Case-insensitive matching consistent with existing patterns - Clear error message distinguishes 'disabled' from 'invalid agent type' - Threaded disabledAgents config into tool factory from pluginConfig ## Changes - tools.ts: Add disabledAgents parameter and validation check - tool-registry.ts: Pass pluginConfig.disabled_agents to factory
potb
force-pushed
the
fix/1716-disabled-agents-call-omo
branch
from
5011935 to
cd0949c
Compare
Contributor
Author
|
Working locally, fixes the issue |
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Simple, focused change: adds disabled_agents filter to callOmoAgent with proper case-insensitive matching. Includes comprehensive test coverage (102 lines) verifying disabled, case-insensitive,Allowed
potb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1716
disabled_agentsconfig exists butcall_omo_agentdoesn't check it — disabled agents can still be called.Threads
disabled_agentsfrom plugin config into the tool factory and adds a case-insensitive check before execution.