fix: guard output.output against undefined in tool.execute.after hooks #1724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Minor additions of type checks to prevent errors, no regressions detected, aligns with criteria for safe changes.
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Three hooks crash with TypeError when output.output is undefined for external MCP tool results. Add null/type guards before calling string methods (.toLowerCase(), .startsWith(), .includes()) on output.output. Affected hooks: - comment-checker: output.output.toLowerCase() at line 95 - edit-error-recovery: output.output.toLowerCase() at line 47 - task-resume-info: output.output.startsWith() at line 24 The tool-output-truncator hook already had this guard (typeof check at line 42), so this aligns the other hooks with that pattern. Fixes code-yeongyu#1720
materializerx
force-pushed
the
fix/guard-output-undefined-in-hooks
branch
from
d9b9050 to
290cf3d
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
marlon-costa-dc
pushed a commit
to marlon-costa-dc/oh-my-opencode
that referenced
this pull request
Feb 10, 2026
marlon-costa-dc
added a commit
to marlon-costa-dc/oh-my-opencode
that referenced
this pull request
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
output.outputin 3 hooks that crash when it'sundefinedTypeError: undefined is not an object (evaluating 'output.output.toLowerCase')for external MCP toolsProblem
Three
tool.execute.afterhooks call string methods onoutput.outputwithout checking if it's defined:comment-checker/hook.tsoutput.output.toLowerCase()(line 95)edit-error-recovery/hook.tsoutput.output.toLowerCase()(line 47)task-resume-info/hook.tsoutput.output.startsWith()(line 24)When OpenCode passes
undefinedforoutput.output(observed with external MCP tools), all three crash withTypeError.Fix
Added
if (!output.output || typeof output.output !== "string") returnguard before accessingoutput.outputmethods. This matches the existing pattern intool-output-truncator.ts(line 42) which already had this guard.Context
output.outputfor themSummary by cubic
Guard output.output against undefined in tool.execute.after hooks to prevent crashes with external MCP tools. Fixes #1720.
Written for commit 290cf3d. Summary will update on new commits.