fix(skill-loader): discover skills from .agents/skills/ directory

[dtateks]

Summary

• Plugin's skill tool overrides OpenCode's native SkillTool, but was missing .agents/skills/ directory support
• Skills placed in .agents/skills/ (project-level) and ~/.agents/skills/ (global) were silently dropped when the plugin was active
• OpenCode natively scans EXTERNAL_DIRS = [".claude", ".agents"], but the plugin only covered .claude/skills/

Root Cause

OpenCode's tool registry (prompt.ts) builds tools as tools[item.id] = .... Since plugin custom tools come after built-in tools, the plugin's skill tool (id: "skill") overwrites OpenCode's native SkillTool. The plugin's skill discovery only searched .claude/skills/ and .opencode/skills/, missing .agents/skills/ entirely.

Changes

• loader.ts: Add discoverProjectAgentsSkills() (.agents/skills/, scope: "project") and discoverGlobalAgentsSkills() (~/.agents/skills/, scope: "user")
• skill-context.ts: Wire new discovery functions into the skill context pipeline
• loader.test.ts: Add 3 test cases covering project-level, global, and integration discovery

Testing

All 17 loader tests pass. No regressions.

---

Summary by cubic

Fixes skill discovery so the plugin always loads skills from .agents/skills at project and user scopes, matching OpenCode’s behavior. Prevents .agents skills from being dropped or gated behind the claude_code.skills flag.

• Bug Fixes

  • Added discoverProjectAgentsSkills and discoverGlobalAgentsSkills; included in discoverSkills/discoverAllSkills with correct priority.
  • Updated skill-context to load .agents/skills unconditionally and merge into project/user scopes.
  • Aligns with OpenCode’s EXTERNAL_DIRS [".claude", ".agents"].

• Tests

  • Added tests for project-level, global, and integrated .agents discovery; mocked homedir for global tests.
  • All loader tests pass.

^{Written for commit e4ed668. Summary will update on new commits.}

[github-actions]

Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA).

To sign the CLA, please comment on this PR with:

I have read the CLA Document and I hereby sign the CLA

This is a one-time requirement. Once signed, all your future contributions will be automatically accepted.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[cubic-dev-ai]

1 issue found across 3 files

Confidence score: 4/5

• This PR looks safe to merge overall, with only a low-severity test isolation concern.
• mock.restore() in src/features/opencode-skill-loader/loader.test.ts doesn’t revert mock.module() in Bun, so a mocked os.homedir() can leak to later tests and cause intermittent failures.
• Pay close attention to src/features/opencode-skill-loader/loader.test.ts - ensure mocked module state doesn’t persist across tests.

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/features/opencode-skill-loader/loader.test.ts">

<violation number="1" location="src/features/opencode-skill-loader/loader.test.ts:629">
P2: `mock.restore()` does not undo `mock.module()` overrides in Bun, so the mocked `os` module remains in the module cache after this test. This can leak the fake `homedir()` into subsequent tests and cause flakiness. Restore the module mock explicitly (e.g., re-mock `os` with the original exports) instead of relying on `mock.restore()`.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: mock.restore() does not undo mock.module() overrides in Bun, so the mocked os module remains in the module cache after this test. This can leak the fake homedir() into subsequent tests and cause flakiness. Restore the module mock explicitly (e.g., re-mock os with the original exports) instead of relying on mock.restore().

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/features/opencode-skill-loader/loader.test.ts, line 629:

<comment>`mock.restore()` does not undo `mock.module()` overrides in Bun, so the mocked `os` module remains in the module cache after this test. This can leak the fake `homedir()` into subsequent tests and cause flakiness. Restore the module mock explicitly (e.g., re-mock `os` with the original exports) instead of relying on `mock.restore()`.</comment>

<file context>
@@ -558,6 +559,120 @@ Skill body.
+        expect(skill?.scope).toBe("user")
+        expect(skill?.definition.description).toContain("A skill from global .agents/skills directory")
+      } finally {
+        mock.restore()
+      }
+    })
</file context>