Skip to content

fix(todo-sync): provide default priority to prevent SQLite NOT NULL violation #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarkFunct wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

fix(todo-sync): provide default priority to prevent SQLite NOT NULL violation #2345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/task/todo-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function syncTaskToTodo(task: Task): TodoInfo | null {
id: task.id,
content: task.subject,
status: todoStatus,
priority: extractPriority(task.metadata),
priority: extractPriority(task.metadata) ?? "medium",
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes syncTaskToTodo() so missing/invalid metadata.priority now yields a concrete priority ("medium") instead of undefined. The existing unit tests in src/tools/task/todo-sync.test.ts currently assert priority is undefined for (a) tasks without metadata, (b) tasks without metadata.priority, and (c) invalid priority values, so they will fail unless updated to expect the new default (and/or the desired fallback behavior is adjusted).

Suggested change
priority: extractPriority(task.metadata) ?? "medium",
priority: extractPriority(task.metadata),

Copilot uses AI. Check for mistakes.
};
}

Expand Down
Loading