feat: upgrade oracle agent primary model to gpt-5.4 #2331
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,7 +81,7 @@ Here's a practical starting configuration: | |
| "explore": { "model": "github-copilot/grok-code-fast-1" }, | ||
|
|
||
| // Architecture consultation: GPT or Claude Opus | ||
| "oracle": { "model": "openai/gpt-5.4", "variant": "high" }, | ||
|
|
||
| // Prometheus inherits sisyphus model; just add prompt guidance | ||
| "prometheus": { "prompt_append": "Leverage deep & quick agents heavily, always in parallel." } | ||
|
|
@@ -253,7 +253,7 @@ Disable categories: `{ "disabled_categories": ["ultrabrain"] }` | |
| |-------|---------------|-------------------| | ||
| | **Sisyphus** | `claude-opus-4-6` | anthropic → github-copilot → opencode → kimi-for-coding → zai-coding-plan | | ||
| | **Hephaestus** | `gpt-5.3-codex` | openai → github-copilot → opencode | | ||
| | **oracle** | `gpt-5.4` | openai → google → anthropic (via github-copilot/opencode) | | ||
| | **librarian** | `glm-4.7` | zai-coding-plan → opencode → anthropic | | ||
| | **explore** | `grok-code-fast-1` | github-copilot → anthropic/opencode → opencode | | ||
| | **multimodal-looker** | `gemini-3-flash` | google → openai → zai-coding-plan → kimi-for-coding → opencode → anthropic | | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ Agent factories following `createXXXAgent(model) → AgentConfig` pattern. Each | |
| |-------|-------|------|------|----------------|---------| | ||
| | **Sisyphus** | claude-opus-4-6 | 0.1 | all | kimi-k2.5 → glm-5 → big-pickle | Main orchestrator, plans + delegates | | ||
| | **Hephaestus** | gpt-5.3-codex | 0.1 | all | gpt-5.2 (copilot) | Autonomous deep worker | | ||
| | **Oracle** | gpt-5.4 | 0.1 | subagent | gemini-3.1-pro → claude-opus-4-6 | Read-only consultation | | ||
| | **Librarian** | kimi-k2.5 | 0.1 | subagent | gemini-3-flash → gpt-5.2 → glm-4.6v | External docs/code search | | ||
| | **Explore** | grok-code-fast-1 | 0.1 | subagent | minimax-m2.5 → claude-haiku-4-5 → gpt-5-nano | Contextual grep | | ||
| | **Multimodal-Looker** | gemini-3-flash | 0.1 | subagent | minimax-m2.5 → big-pickle | PDF/image analysis | | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -169,15 +169,14 @@ describe("createBuiltinAgents with model overrides", () => { | |
| test("Oracle uses connected provider fallback when availableModels is empty and cache exists", async () => { | ||
| // #given - connected providers cache has "openai", which matches oracle's first fallback entry | ||
| const cacheSpy = spyOn(connectedProvidersCache, "readConnectedProvidersCache").mockReturnValue(["openai"]) | ||
| const fetchSpy = spyOn(shared, "fetchAvailableModels").mockResolvedValue(new Set()) | ||
| // #when | ||
| const agents = await createBuiltinAgents([], {}, undefined, TEST_DEFAULT_MODEL, undefined, undefined, [], undefined, undefined) | ||
| expect(agents.oracle.model).toBe("openai/gpt-5.4") | ||
| expect(agents.oracle.reasoningEffort).toBe("medium") | ||
| expect(agents.oracle.thinking).toBeUndefined() | ||
| cacheSpy.mockRestore?.() | ||
| fetchSpy.mockRestore?.() | ||
| }) | ||
|
|
||
| test("Oracle created without model field when no cache exists (first run scenario)", async () => { | ||
|
|
@@ -473,14 +472,13 @@ describe("createBuiltinAgents without systemDefaultModel", () => { | |
| test("agents created via connected cache fallback even without systemDefaultModel", async () => { | ||
| // #given - connected cache has "openai", which matches oracle's fallback chain | ||
| const cacheSpy = spyOn(connectedProvidersCache, "readConnectedProvidersCache").mockReturnValue(["openai"]) | ||
| const fetchSpy = spyOn(shared, "fetchAvailableModels").mockResolvedValue(new Set()) | ||
| // #when | ||
| const agents = await createBuiltinAgents([], {}, undefined, undefined) | ||
| expect(agents.oracle).toBeDefined() | ||
| expect(agents.oracle.model).toBe("openai/gpt-5.4") | ||
| cacheSpy.mockRestore?.() | ||
| fetchSpy.mockRestore?.() | ||
| }) | ||
|
|
||
| test("agents NOT created when no cache and no systemDefaultModel (first run without defaults)", async () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -216,7 +216,7 @@ exports[`generateModelConfig single native provider uses OpenAI models when only | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "openai/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -284,7 +284,7 @@ exports[`generateModelConfig single native provider uses OpenAI models with isMa | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "openai/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -474,7 +474,7 @@ exports[`generateModelConfig all native providers uses preferred models from fal | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "openai/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -549,7 +549,7 @@ exports[`generateModelConfig all native providers uses preferred models with isM | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "openai/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -625,7 +625,7 @@ exports[`generateModelConfig fallback providers uses OpenCode Zen models when on | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "opencode/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -700,7 +700,7 @@ exports[`generateModelConfig fallback providers uses OpenCode Zen models with is | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "opencode/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -771,7 +771,7 @@ exports[`generateModelConfig fallback providers uses GitHub Copilot models when | |
| "model": "github-copilot/gemini-3-flash-preview", | ||
| }, | ||
| "oracle": { | ||
| "model": "github-copilot/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -837,7 +837,7 @@ exports[`generateModelConfig fallback providers uses GitHub Copilot models with | |
| "model": "github-copilot/gemini-3-flash-preview", | ||
| }, | ||
| "oracle": { | ||
| "model": "github-copilot/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -1019,7 +1019,7 @@ exports[`generateModelConfig mixed provider scenarios uses Claude + OpenCode Zen | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "opencode/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -1094,7 +1094,7 @@ exports[`generateModelConfig mixed provider scenarios uses OpenAI + Copilot comb | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "openai/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -1296,7 +1296,7 @@ exports[`generateModelConfig mixed provider scenarios uses all fallback provider | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "github-copilot/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -1371,7 +1371,7 @@ exports[`generateModelConfig mixed provider scenarios uses all providers togethe | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "openai/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
@@ -1446,7 +1446,7 @@ exports[`generateModelConfig mixed provider scenarios uses all providers with is | |
| "variant": "medium", | ||
| }, | ||
| "oracle": { | ||
| "model": "openai/gpt-5.4", | ||
| "variant": "high", | ||
| }, | ||
| "prometheus": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -322,7 +322,7 @@ describe("generateOmoConfig - model fallback system", () => { | |||||
| // #then Sisyphus is omitted (requires all fallback providers) | ||||||
| expect((result.agents as Record<string, { model: string }>).sisyphus).toBeUndefined() | ||||||
| // #then Oracle should use native OpenAI (first fallback entry) | ||||||
| expect((result.agents as Record<string, { model: string }>).oracle.model).toBe("openai/gpt-5.4") | ||||||
|
There was a problem hiding this comment. P1: Custom agent: Opencode Compatibility Upgrading to Prompt for AI agents
Suggested change
|
||||||
| // #then multimodal-looker should use native OpenAI (first fallback entry is gpt-5.3-codex) | ||||||
| expect((result.agents as Record<string, { model: string }>)["multimodal-looker"].model).toBe("openai/gpt-5.3-codex") | ||||||
| }) | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ export const CLI_AGENT_MODEL_REQUIREMENTS: Record<string, ModelRequirement> = { | |
| }, | ||
| oracle: { | ||
| fallbackChain: [ | ||
| { providers: ["openai", "github-copilot", "opencode"], model: "gpt-5.4", variant: "high" }, | ||
|
There was a problem hiding this comment. P1: Custom agent: Opencode Compatibility The Prompt for AI agents |
||
| { providers: ["google", "github-copilot", "opencode"], model: "gemini-3.1-pro", variant: "high" }, | ||
| { providers: ["anthropic", "github-copilot", "opencode"], model: "claude-opus-4-6", variant: "max" }, | ||
| ], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -191,7 +191,7 @@ describe("resolveVariantForModel", () => { | |
| test("returns correct variant for oracle agent with openai", () => { | ||
| // given | ||
| const config = {} as OhMyOpenCodeConfig | ||
| const model = { providerID: "openai", modelID: "gpt-5.4" } | ||
|
|
||
| // when | ||
| const variant = resolveVariantForModel(config, "oracle", model) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,19 +7,19 @@ import { | |
| } from "./model-requirements" | ||
|
|
||
| describe("AGENT_MODEL_REQUIREMENTS", () => { | ||
| test("oracle has valid fallbackChain with gpt-5.4 as primary", () => { | ||
| // given - oracle agent requirement | ||
| const oracle = AGENT_MODEL_REQUIREMENTS["oracle"] | ||
|
|
||
| // when - accessing oracle requirement | ||
| // then - fallbackChain exists with gpt-5.4 as first entry | ||
| expect(oracle).toBeDefined() | ||
| expect(oracle.fallbackChain).toBeArray() | ||
| expect(oracle.fallbackChain.length).toBeGreaterThan(0) | ||
|
|
||
| const primary = oracle.fallbackChain[0] | ||
| expect(primary.providers).toContain("openai") | ||
| expect(primary.model).toBe("gpt-5.4") | ||
| expect(primary.variant).toBe("high") | ||
| }) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -30,7 +30,7 @@ export const AGENT_MODEL_REQUIREMENTS: Record<string, ModelRequirement> = { | |||||||
| }, | ||||||||
| oracle: { | ||||||||
| fallbackChain: [ | ||||||||
| { providers: ["openai", "github-copilot", "opencode"], model: "gpt-5.4", variant: "high" }, | ||||||||
|
There was a problem hiding this comment. P1: Custom agent: Opencode Compatibility The Prompt for AI agents
Suggested change
|
||||||||
| { providers: ["google", "github-copilot", "opencode"], model: "gemini-3.1-pro", variant: "high" }, | ||||||||
| { providers: ["anthropic", "github-copilot", "opencode"], model: "claude-opus-4-6", variant: "max" }, | ||||||||
| ], | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ const TEST_AVAILABLE_MODELS = new Set([ | |
| "google/gemini-3.1-pro", | ||
| "google/gemini-3-flash", | ||
| "openai/gpt-5.2", | ||
| "openai/gpt-5.4", | ||
| "openai/gpt-5.3-codex", | ||
| ]) | ||
|
|
||
|
|
@@ -53,7 +54,7 @@ describe("sisyphus-task", () => { | |
| models: { | ||
| anthropic: ["claude-opus-4-6", "claude-sonnet-4-6", "claude-haiku-4-5"], | ||
| google: ["gemini-3.1-pro", "gemini-3-flash"], | ||
| openai: ["gpt-5.2", "gpt-5.4", "gpt-5.3-codex"], | ||
| }, | ||
| connected: ["anthropic", "google", "openai"], | ||
| updatedAt: "2026-01-01T00:00:00.000Z", | ||
|
|
@@ -3375,7 +3376,7 @@ describe("sisyphus-task", () => { | |
| app: { | ||
| agents: async () => ({ | ||
| data: [ | ||
| { name: "oracle", mode: "subagent", model: { providerID: "openai", modelID: "gpt-5.4" } }, | ||
| ], | ||
| }), | ||
| }, | ||
|
|
@@ -3442,7 +3443,7 @@ describe("sisyphus-task", () => { | |
| app: { | ||
| agents: async () => ({ | ||
| data: [ | ||
| { name: "oracle", mode: "subagent", model: { providerID: "openai", modelID: "gpt-5.4" } }, | ||
| ], | ||
| }), | ||
| }, | ||
|
|
@@ -3551,11 +3552,11 @@ describe("sisyphus-task", () => { | |
| ) | ||
|
|
||
| // then - should resolve via AGENT_MODEL_REQUIREMENTS fallback chain for oracle | ||
| // oracle fallback chain: gpt-5.4 (openai) > gemini-3.1-pro (google) > claude-opus-4-6 (anthropic) | ||
| // Since openai is in connectedProviders, should resolve to openai/gpt-5.4 | ||
| expect(promptBody.model).toBeDefined() | ||
| expect(promptBody.model.providerID).toBe("openai") | ||
| expect(promptBody.model.modelID).toContain("gpt-5.4") | ||
| }, { timeout: 20000 }) | ||
| }) | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Incomplete documentation update: other sections of this file still list
GPT-5.2for the Oracle agent.Prompt for AI agents