Merged
Conversation
- globals.css: body::before/::after 분리선에 pointer-events: none 추가 → 상호작용 요소 위에 겹치는 divider가 클릭/탭을 차단하지 않도록 수정 - section.tsx: p-app → p-6 (Tailwind --spacing-* 네임스페이스 사용) → Tailwind v4에서 --padding-app은 p-* 유틸리티를 자동 생성하지 않음 - section.tsx: text-md → text-sm (Tailwind 표준 스케일) → text-md는 Tailwind 기본 타이포그래피 스케일에 없는 클래스 - field.tsx: FieldContext 추가 및 useField() hook export → aria-describedby 지원을 위해 descriptionId/errorId를 context로 노출 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
Test Coverage
@cocso-ui/react — File Coverage
@cocso-ui/baseframe — File Coverage
|
Array.at() 사용으로 인한 check-types 에러 수정. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- link.tsx: ExternalIcon, variant CSS vars, indicator 명시 테스트 추가 → funcs 54%→100%, lines 66%→100% - field.tsx: useField() hook 컨텍스트 검증 테스트 추가 → funcs 50%→100% - spinner.tsx: 6가지 variant 색상, style 병합 테스트 추가 → funcs 60%→100% - switch.tsx: size large, variant CSS vars, custom id 테스트 추가 → funcs 68%→100% - tailwind.ts: banner 옵션, generateTailwindCSS 직접 호출, 빈 컬렉션 브랜치 커버 → branch 68%→89% - validate.ts: ShadowLayer/Shadow 토큰 참조 검증 테스트 추가 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- css-vars.ts: :root 폴백, banner 옵션, generateCssVariables 직접 호출 커버 → branch 71%→개선 - resolve.ts: resolveTokenRef/resolveValue throw 경로, ShadowLayer/Shadow 재귀 해결 커버 신규 테스트 파일 추가 (13 cases) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CSS 토큰, Typography/Link 컴포넌트, 테스트 일괄 반영. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- next dev에 --hostname 0.0.0.0 --port 6005 옵션 추가 - globals.css divider 스타일 CSS 속성 순서 Biome 기준으로 정렬 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
621fdbb에서 --cocso-text-base를 15px → 16px로 변경했으나 골든 스냅샷이 미반영되어 CI Test 실패 발생 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ohprettyhak
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a33749c828
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…aseframe Add comprehensive JSDoc documentation to 40 TypeScript files covering React component props/functions, design token exports, and the baseframe token generator pipeline. No logic changes — comments only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
JSDoc/TSDoc 주석 추가 (4fbf44c)전체 프로젝트에 JSDoc/TSDoc 주석을 추가했습니다. 변경 범위
검증
|
Align the default font size for type="custom" with the base token change from commit 621fdbb (text-base 15px → 16px). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ohprettyhak
changed the title
ohprettyhak
changed the title
ohprettyhak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globals.css:body::before/::after분리선에pointer-events: none추가 — 고정된 divider 가상 요소가 클릭/탭 입력을 차단하는 문제 수정section.tsx:p-app→p-6,text-md→text-sm— Tailwind v4 미지원 유틸리티 제거field.tsx:FieldContext추가 및useField()hook export —aria-describedby지원을 위한descriptionId/errorIdcontext 노출fix(tokens):--cocso-text-base15px → 16px 복원 (PR feat: design system v2 — radius 토큰, 스크롤 개선, 웹 가이드라인 준수 #96 의도 수정)fix(baseframe): tsconfigtargetES2020 → ES2022,resolve.test.ts정규식 최상위 이동 (Biome useTopLevelRegex)test: 커버리지 낮은 파일 테스트 보강 (link/field/spinner/switch/tailwind/validate), css-vars/resolve 브랜치 커버리지 개선fix(baseframe): golden snapshottoken.css.expectedtext-base 16px로 업데이트 — CI Test 실패 수정chore(website): dev 서버 호스트/포트 고정, CSS 속성 순서 정렬docs: JSDoc/TSDoc 주석 추가 — React 컴포넌트(22), 토큰(4), 유틸리티(1), ecosystem/baseframe(13) 총 40개 파일 (+733 라인)fix(typography):type="custom"기본 font-size 15px → 16px — base token 변경과 정합성 맞춤Test plan
body::before/::after) 위 요소 클릭 정상 동작useField()로aria-describedby참조 가능--cocso-text-base: 16px적용 확인type="custom"기본 font-size 16px 정합성 확인 (321/321 테스트 통과)🤖 Generated with Claude Code