Fix: fix(circle): join() has redundant member_count updates (wrapping_add + checked_add) (Auto-Generated) - #413
Open
precious1joe wants to merge 2 commits into
Conversation
Contributor
|
Same as the other auto-generated circle fix: based on a stale snapshot of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #413
This pull request was generated automatically and scoped strictly to issue #413.
Changes
Removed the redundant wrapping_add line for member_count in the join function of packages/circle/src/contract.rs, keeping only the checked_add arithmetic with CircleError::InvalidAmount error handling.
Verification
Linked with
Closes #413so the Drips Wave bot resolves the issue on merge.