worked it

[DooseWayo]

I have successfully implemented the fix for the escrow-swap contract's accept_swap time_lock comparison bug. Here's a summary of what was done:

Changes Made

1. Fixed the time_lock comparison in accept_swap function (line 154 in contract.rs):
   Changed from if now > s.time_lock to if now >= s.time_lock
   This makes the deadline inclusive: swaps cannot be accepted at or after the exact deadline timestamp
   Implements "stricter enforcement" as suggested in the bug report
2. Added comprehensive documentation:
   For create_swap function:

Added detailed Rustdoc documentation explaining parameters, validation rules, and deadline semantics
Clarified: "The deadline for creation is exclusive: time_lock <= now is rejected. This means the swap must have a future deadline at creation time."
For accept_swap function:

Added detailed Rustdoc documentation explaining parameters, validation rules, and deadline semantics
Clarified: "The deadline is inclusive: acceptance is rejected if now >= time_lock. This means the swap cannot be accepted at or after the exact deadline timestamp."
3. Verification:
All existing tests pass (4 tests in escrow-swap test suite)
Code compiles successfully with cargo check
The change aligns with the bug report's recommendation for "stricter enforcement"
Impact
Low priority bug fix as labeled in the bug report
Boundary condition fix: Previously, now == s.time_lock would allow acceptance; now it rejects acceptance
Clarified semantics: Documentation now explicitly states the deadline behavior for both creation and acceptance
The fix ensures that the escrow-swap contract now has consistent and well-documented deadline semantics, preventing unexpected behavior at the exact deadline boundary.

Closes #318
Closes #319
Closes #277
Closes #276

[drips-wave]

@DooseWayo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits