feat: enhance UpdateStats display with progress bar and error handling #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeh0
reviewed
Oct 26, 2025
| sub_messages.push(format!( | ||
| "{num_reprocesses} REPROCESSED on flow/logic changes or reexport" | ||
| )); | ||
| segments.push((num_deletions, "-", format!("\x1B[90m(-{} removed)\x1B[0m", num_deletions))); |
There was a problem hiding this comment.
We're using the owo_colors crate to generate color codings, example:
Lines 369 to 370 in 67da574
We may want to use the same here.
BTW, can you also do a test by running it and redirect stdout to a file? Want to make sure the output file content make sense when the stdout isn't tty (usually in this case we shouldn't output the control characters, and I think the owo_colors crate should handle this automatically)
There was a problem hiding this comment.
@georgeh0 , thanks for the comments , working on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #343