metrics: redesign disk usage metrics #5504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we maintain the metrics that are used for disk usage
calculations are very messy. They are updated incrementally with
special code paths which can be fragile. And they are not consistent
with sibling metrics (for example:
Tables.Live.Alluses virtual tablesizes, whereas
Tables.Live.Localuses backing sizes)This change redesigns these metrics. We specialize the metrics to
focus on disk usage, and thus only include physical tables and
physical backings. We now use the (improved) disk space aggregator and
new blob size aggregator on demand, only when metrics are needed.